ROCm/composable_kernel
1
0
Fork 0
mirror of https://github.com/ROCm/composable_kernel.git synced 2026-05-03 05:01:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

[CK TILE GEMM] Fixed the regression issue with transpose C in Quant Gemm (#2819)

Browse Source 
The numerical error was introduced after merging row/col quant. And it is fixed.
This commit is contained in:
Cong Ma
2025-09-11 12:38:16 -06:00
committed by GitHub
parent 28e12c62a2
commit 2ed39f8d91
2 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
include/ck_tile/ops/gemm_group_quant/block/block_universal_gemm_as_aquant_bs_cr.hpp
View File

@@ -358,10 +358,11 @@ struct AQuantBlockUniversalGemmAsBsCr : public BlockGemmAQuantBase<Problem_>
if constexpr(Traits::PreshuffleQuant)
{
static_assert(false,
"It is not supported yet to enable both Preshuffle and "
"TransposeC.");
if constexpr(Traits::TransposeC) // transposed C
{
static_assert(false,
"It is not supported yet to enable both Preshuffle.");
// TODO:
// A new tile distribution is needed for the Preshuffle and
// Transpose combination. For instance, with mnk at 16x16x32, lanes
@@ -455,7 +456,7 @@ struct AQuantBlockUniversalGemmAsBsCr : public BlockGemmAQuantBase<Problem_>
}
else
{
if(Traits::TransposeC) // transposed C
if constexpr(Traits::TransposeC) // transposed C
{
constexpr index_t reg_offset = mIter * Traits::AQPerBlock + kQScale;
constexpr auto tbuf_offset = number<