From 77c7fb1e6b6b5d3b60c1c5e34aa647593ea9c476 Mon Sep 17 00:00:00 2001 From: Yi DING Date: Mon, 28 Apr 2025 07:26:05 +0800 Subject: [PATCH] Fix fp8 convert & add option for basic example (#2129) [ROCm/composable_kernel commit: 8add2cf45d8c9b298d820c6cf7f158cc13936352] --- example/ck_tile/03_gemm/CMakeLists.txt | 1 + include/ck_tile/core/numeric/float8.hpp | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/example/ck_tile/03_gemm/CMakeLists.txt b/example/ck_tile/03_gemm/CMakeLists.txt index 61c3a57391..411db2e317 100644 --- a/example/ck_tile/03_gemm/CMakeLists.txt +++ b/example/ck_tile/03_gemm/CMakeLists.txt @@ -5,4 +5,5 @@ if(CK_USE_OCP_FP8) list(APPEND EXAMPLE_GEMM_COMPILE_OPTIONS -DCK_TILE_USE_OCP_FP8) endif() list(APPEND EXAMPLE_GEMM_COMPILE_OPTIONS -mllvm -enable-noalias-to-md-conversion=0) +target_compile_options(tile_example_gemm_basic PRIVATE ${EXAMPLE_GEMM_COMPILE_OPTIONS}) target_compile_options(tile_example_gemm_universal PRIVATE ${EXAMPLE_GEMM_COMPILE_OPTIONS}) diff --git a/include/ck_tile/core/numeric/float8.hpp b/include/ck_tile/core/numeric/float8.hpp index a4e8ca6a2b..b5da468319 100644 --- a/include/ck_tile/core/numeric/float8.hpp +++ b/include/ck_tile/core/numeric/float8.hpp @@ -530,7 +530,7 @@ CK_TILE_HOST_DEVICE DstT run_cast_from_f8(SrcT x) } else { - if(x == 0x80) + if(x == SrcT(0x80)) { return fNeg0; }