From 7c9257128dc776ceea53d8642aa4dfbbedd51ce3 Mon Sep 17 00:00:00 2001 From: Taylor Ding Date: Wed, 13 Nov 2024 11:20:38 -0500 Subject: [PATCH] Move checks for compatibility from Argument() to IsSupportedArgument() (#1653) [ROCm/composable_kernel commit: 73f02a108347d626ee9b31789f0ff8b26ef87006] --- ..._grouped_conv_bwd_data_multiple_d_wmma_cshuffle.hpp | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/include/ck/tensor_operation/gpu/device/impl/device_grouped_conv_bwd_data_multiple_d_wmma_cshuffle.hpp b/include/ck/tensor_operation/gpu/device/impl/device_grouped_conv_bwd_data_multiple_d_wmma_cshuffle.hpp index 6bb5d431c9..17b7d962db 100644 --- a/include/ck/tensor_operation/gpu/device/impl/device_grouped_conv_bwd_data_multiple_d_wmma_cshuffle.hpp +++ b/include/ck/tensor_operation/gpu/device/impl/device_grouped_conv_bwd_data_multiple_d_wmma_cshuffle.hpp @@ -381,10 +381,6 @@ struct DeviceGroupedConvBwdDataMultipleD_Wmma_CShuffle { tildes = {i_ztilde, i_ytilde, i_xtilde}; } - else - { - throw std::runtime_error("wrong! only implemented for 2D and 3D now"); - } const auto a_grid_desc_ak0_m_ak1 = transform_conv_to_gemm.template MakeADescriptor_AK0_M_AK1( @@ -749,6 +745,12 @@ struct DeviceGroupedConvBwdDataMultipleD_Wmma_CShuffle return false; } } + + // check number of dimension, only implemented for 2D and 3D now + if(NDimSpatial != 2 && NDimSpatial != 3) + { + return false; + } return true; }