ROCm/composable_kernel
1
0
Fork 0
mirror of https://github.com/ROCm/composable_kernel.git synced 2026-04-20 06:49:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

Jimniu/ ck tile gemm stride validation (#2710)

Browse Source 
* Add stride validation for gemm_basic

* change default stride statement

* Fix build error

* Fix pre-commit failure

* Addressed PR comments

* clear the redundant code

* clang format

---------

Co-authored-by: mkumar16-amd <mkumar16@amd.com>
Co-authored-by: ThomasNing <thomas.ning@amd.com>
This commit is contained in:
Jimniu
2025-10-29 22:45:09 -04:00
committed by GitHub
parent 1e77695fe8
commit 8c4cb4f9f4
4 changed files with 77 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

51
include/ck_tile/core/utility/gemm_validation.hpp Normal file
View File

@@ -0,0 +1,51 @@
// SPDX-License-Identifier: MIT
// Copyright (c) 2018-2025, Advanced Micro Devices, Inc. All rights reserved.
#pragma once
#include <string>
#include <stdexcept>
#include "ck_tile/core/config.hpp"
namespace ck_tile {
inline void
validate_stride(std::string Layout, int M, int N, int stride, const std::string& stride_name)
{
if(Layout == "C" && stride < M)
{
throw std::runtime_error("For ColumnMajor layout, " + stride_name + "(" +
std::to_string(stride) + ") must be greater or equal to dim " +
std::to_string(M));
}
if(Layout == "R" && stride < N)
{
throw std::runtime_error("For RowMajor layout, " + stride_name + "(" +
std::to_string(stride) + ") must be greater or equal to dim " +
std::to_string(N));
}
}
inline void validate_gemm_stride(std::string a_layout,
std::string b_layout,
std::string c_layout,
int M,
int N,
int K,
int Stride_A,
int Stride_B,
int Stride_C)
{
// set default stride
if(Stride_A <= 0)
Stride_A = (a_layout == "R") ? K : M;
if(Stride_B <= 0)
Stride_B = (b_layout == "R") ? N : K;
if(Stride_C <= 0)
Stride_C = (c_layout == "R") ? N : M;
validate_stride(a_layout, M, K, Stride_A, "Stride_A");
validate_stride(b_layout, K, N, Stride_B, "Stride_B");
validate_stride(c_layout, M, N, Stride_C, "Stride_C");
}
} // namespace ck_tile