ROCm/composable_kernel
1
0
Fork 0
mirror of https://github.com/ROCm/composable_kernel.git synced 2026-05-11 08:50:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

[CK_TILE] Refine pk_fp4's fill, pack, and unpack (#2845)

Browse Source 
* fix bug

* let pack/unpack return pk_fp4_t

* fix clang-format
This commit is contained in:
Gino Lu
2025-09-17 10:54:06 +08:00
committed by GitHub
parent db79fad16f
commit c2997f2b7f
3 changed files with 70 additions and 36 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
test/ck_tile/data_type/test_pk_fp4.cpp
View File

@@ -2,6 +2,7 @@
// Copyright (c) 2025, Advanced Micro Devices, Inc. All rights reserved.
#include "gtest/gtest.h"
#include <vector>
#include <hip/hip_runtime.h>
#include "ck_tile/core.hpp"
@@ -29,6 +30,12 @@ TEST(PackedFp4, NumericLimits)
EXPECT_EQ(ck_tile::numeric<pk_fp4_t>::epsilon(), pk_fp4_t{0b00010001});
EXPECT_EQ(ck_tile::numeric<pk_fp4_t>::round_error(), pk_fp4_t{0b00010001});
}
TEST(PackedFp4, fill)
{
std::vector<pk_fp4_t> v_fp4(4);
ck_tile::FillUniformDistribution<pk_fp4_t>{1.f, 1.f}(v_fp4);
EXPECT_EQ(v_fp4[0].get(), pk_fp4_t{0b00100010}.get());
}
TEST(PackedFp4, ConvertBasic)
{
EXPECT_EQ(ck_tile::convert_to_type<pk_fp4_t>(0.0f), pk_fp4_t{0b00000000}.get());
@@ -102,7 +109,7 @@ struct SrcPkfp4Dst
// ex: fp32_t -> fp4 -> bf16_t
dst[i] = toDST(toPF4(src[i]));
// ex: fp32x2_t -> pk_fp4 -> unpack<0> -> bf16_t
dst[i + 1] = toDST(toPF4(toPF4(input2).unpack(number<1>{})));
dst[i + 1] = toDST(toPF4(input2).unpack(number<1>{}));
}
else
{