From e20e646f8c537015478261a503fb01336538f623 Mon Sep 17 00:00:00 2001
From: Kevin Abraham <kevin.abraham@streamhpc.com>
Date: Mon, 15 Dec 2025 12:51:15 +0000
Subject: [PATCH] adressed review comments

---
 .../include/ck_tile/builder/testing/conv_fwd.hpp      |  2 +-
 .../include/ck_tile/builder/testing/testing.hpp       |  2 +-
 include/ck/library/utility/device_memory.hpp          | 11 -----------
 3 files changed, 2 insertions(+), 13 deletions(-)

diff --git a/experimental/builder/include/ck_tile/builder/testing/conv_fwd.hpp b/experimental/builder/include/ck_tile/builder/testing/conv_fwd.hpp
index 62d265894a..1763a3d93b 100644
--- a/experimental/builder/include/ck_tile/builder/testing/conv_fwd.hpp
+++ b/experimental/builder/include/ck_tile/builder/testing/conv_fwd.hpp
@@ -247,7 +247,7 @@ UniqueInputs<SIGNATURE> alloc_inputs(const Args<SIGNATURE>& args)
 template <auto SIGNATURE>
     requires ValidConvSignature<SIGNATURE> && ConvDirectionIsForward<SIGNATURE> &&
              ValidUniqueInputs<SIGNATURE>
-void init_inputs(const Args<SIGNATURE>& args, UniqueInputs<SIGNATURE>& inputs)
+void init_inputs(const Args<SIGNATURE>& args, Inputs<SIGNATURE>& inputs)
 {
     init_tensor_buffer_uniform_fp(inputs.input_buf, args.make_input_descriptor(), -2.0f, 2.0f);
     init_tensor_buffer_uniform_fp(inputs.weight_buf, args.make_weight_descriptor(), -2.0f, 2.0f);
diff --git a/experimental/builder/include/ck_tile/builder/testing/testing.hpp b/experimental/builder/include/ck_tile/builder/testing/testing.hpp
index a0dfa27409..71f420881b 100644
--- a/experimental/builder/include/ck_tile/builder/testing/testing.hpp
+++ b/experimental/builder/include/ck_tile/builder/testing/testing.hpp
@@ -217,7 +217,7 @@ UniqueInputs<SIGNATURE> alloc_inputs(const Args<SIGNATURE>& args);
 /// @see tensor_initialization
 template <auto SIGNATURE>
     requires ValidUniqueInputs<SIGNATURE>
-void init_inputs(const Args<SIGNATURE>& args, UniqueInputs<SIGNATURE>& inputs);
+void init_inputs(const Args<SIGNATURE>& args, Inputs<SIGNATURE>& inputs);
 
 /// @brief Allocate outputs corresponding to a signature.
 ///
diff --git a/include/ck/library/utility/device_memory.hpp b/include/ck/library/utility/device_memory.hpp
index 889bdb2829..af5cb6ec28 100644
--- a/include/ck/library/utility/device_memory.hpp
+++ b/include/ck/library/utility/device_memory.hpp
@@ -91,13 +91,6 @@ void DeviceMem::FillUniformRandFp(float min_value, float max_value)
         throw std::runtime_error("wrong! not entire DeviceMem will be filled");
     }
 
-    if(std::nextafter(min_value, max_value) >= max_value)
-    {
-        // nextafter is not defined for non-standard data types, skip test for now
-        // throw std::runtime_error("Error while filling device tensor with random integer data:
-        // insufficient precision in specified range");
-    }
-
     size_t packed_size = packed_size_v<T>;
     fill_tensor_uniform_rand_fp_values<<<256, 256>>>(
         static_cast<T*>(mpDeviceBuf), min_value, max_value, (mMemSize * packed_size) / sizeof(T));
@@ -106,10 +99,6 @@ void DeviceMem::FillUniformRandFp(float min_value, float max_value)
 template <typename T>
 void DeviceMem::FillNormalRandFp(float sigma, float mean)
 {
-    if(mMemSize % sizeof(T) != 0)
-    {
-        throw std::runtime_error("wrong! not entire DeviceMem will be filled");
-    }
 
     fill_tensor_norm_rand_fp_values<<<256, 256>>>(
         static_cast<T*>(mpDeviceBuf), sigma, mean, mMemSize / sizeof(T));