From eae37a7b6fd6ab819ef9ff4276703dfdc444bd99 Mon Sep 17 00:00:00 2001 From: Anthony Chang Date: Wed, 30 Nov 2022 00:57:26 +0800 Subject: [PATCH] Fix split-k gemm test (#231) * properly return error flag; reveals bug in split-k gemm * fix bug in split k * update split-k test case Co-authored-by: Chao Liu [ROCm/composable_kernel commit: 236bd148b98c7f1ec61ee850fcc0c5d433576305] --- test/gemm_split_k/gemm_split_k.cpp | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/test/gemm_split_k/gemm_split_k.cpp b/test/gemm_split_k/gemm_split_k.cpp index d5cb03d613..1edb5769c6 100644 --- a/test/gemm_split_k/gemm_split_k.cpp +++ b/test/gemm_split_k/gemm_split_k.cpp @@ -226,9 +226,8 @@ int main(int argc, char* argv[]) std::vector test_cases; if(argc == 1) { - test_cases = {{GemmMatrixLayout::MK_KN_MN, 3, 3, 3, 3, 3, 3, 1}}; - // JD: Populate with more and meaningful - return 0; + test_cases = {{GemmMatrixLayout::MK_KN_MN, 1024, 1024, 1024, 1024, 1024, 1024, 2}, + {GemmMatrixLayout::MK_KN_MN, 1024, 1024, 1024, 1024, 1024, 1024, 8}}; } else if(argc == 9) { @@ -253,11 +252,10 @@ int main(int argc, char* argv[]) printf("arg2 to 7: M, N, K, StrideA, StrideB, StrideC KBatch\n"); return -1; } + bool error = false; for(const auto& kinder : test_cases) { - const auto res = test_gemm(kinder); - if(!res) - return -1; + error |= test_gemm(kinder); } - return 0; + return error ? 1 : 0; }