Commit Graph

2 Commits

Author SHA1 Message Date
John Shumway
2f0242c5ab Add instance traits for two more grouped forward convolutions (#3112)
[ROCm/composable_kernel commit: cafaeb6b7b]
2025-10-29 16:04:13 +01:00
John Shumway
c237ad2950 [CK_BUILDER] Test and fix instance traits utils. (#3096)
* Refactor instance_traits_util and add unit tests tests

* Address reviewer comments.

Just adds some TODOs to indicate deprecated layouts in our reflection. Our strategy is to leave the reflection code broad (covering deprecated features), but keep the builder concepts narrow. Once we've removed deprecated features from all instances, we can remove them from reflection.

Also add a comment to the cmake to explain the unit test target test_conv_builder.

* Addressed more reviewer comments.

* Remove duplicate PassThrough::name

Accidentally added this field to the end of the struct, too. The `name` field should be a the start of the struct for consistency.

[ROCm/composable_kernel commit: 54746e9329]
2025-10-27 22:14:08 -07:00