mirror of
https://github.com/ROCm/composable_kernel.git
synced 2026-03-17 05:37:38 +00:00
* Decouple configure/build/test tools from Docker Create a two-layer tool architecture: - Core tools (ck-configure, ck-build, ck-test): Environment-agnostic, work on any system with ROCm - no Docker dependency - Container tools (ck-docker): Manage Docker containers and delegate to core tools via docker exec Changes: - Add ck-configure: New CMake configuration tool with preset support, native GPU detection, and flexible options - Refactor ck-build: Remove Docker dependency, add --configure and --list options, call ninja directly - Refactor ck-test: Remove Docker dependency, add CTest integration with --smoke/--regression/--all options - Enhance common.sh: Add native GPU detection, build directory utils, and output helpers - Update ck-docker: Add configure/build/test/exec commands that delegate to core tools inside container This enables: - Native development on ROCm hosts without Docker - Simpler CI/CD integration - Consistent behavior inside and outside containers Co-Authored-By: Claude <noreply@anthropic.com> * Add ck-rocprof: GPU profiling tool for rocprof-compute Adds a command-line profiling tool to simplify GPU performance analysis workflow using AMD rocprof-compute. Features: - Easy setup with automatic Python venv configuration - Simple CLI: setup, run, analyze, compare, list - Automatic GPU architecture detection - Focus on LDS metrics (Block 12) for bank conflict analysis - Comprehensive documentation with examples and troubleshooting Usage: ck-rocprof setup # One-time environment setup ck-rocprof run <name> <executable> # Profile executable ck-rocprof analyze <name> [block] # Analyze metrics ck-rocprof compare <name1> <name2> # Compare two runs ck-rocprof list # List available runs * Make ck-rocprof documentation concise and improve Docker integration - Streamlined documentation from 416 to 157 lines (62% reduction) - Focused on essential commands, metrics, and workflows - Enhanced script to run all operations inside Docker containers - Fixed workload directory path and improved container management - Added automatic rocprofiler-compute installation and dependency handling * Add --no-roof flag to ck-rocprof profile command Skip roofline analysis by default to speed up profiling. Roofline analysis can add significant time to profiling runs but is not needed for most LDS bank conflict analysis workflows. * Make ck-rocprof work independently of Docker Add native execution mode that runs rocprof-compute directly on the host system when available, falling back to Docker mode when not. Key changes: - Auto-detect native mode when rocprof-compute is in PATH or common locations - Add execution mode wrappers (exec_cmd, file_exists, dir_exists, etc.) - Native mode stores venv at .ck-rocprof-venv in project root - Native mode stores workloads at build/workloads/ - Support user-installed rocprofiler-compute (e.g., ~/.local/rocprofiler-compute) - Add CK_FORCE_DOCKER env var to force Docker mode - Update help message to show current execution mode - Maintain full backward compatibility with existing Docker workflow Tested successfully with rocprofiler-compute 3.4.0 installed from source on MI300X GPU in native mode. Co-Authored-By: Claude <noreply@anthropic.com> * Add clean/status commands and improve ck-rocprof robustness - Add 'clean' command to remove profiling runs (supports --all) - Add 'status' command to show configuration and environment info - Add workload name validation to prevent path traversal attacks - Fix uv installation to use pip instead of curl for reliability - Add cross-platform stat support for macOS compatibility - Consolidate ROCPROF_CANDIDATES to avoid code duplication - Expand help documentation with all profiling block descriptions - Fix Docker wrapper script escaping issues Co-Authored-By: Claude <noreply@anthropic.com> * Fix analyze command to use correct workload path rocprof-compute stores results directly in the workload directory (pmc_perf.csv) rather than in a GPU architecture subdirectory. Updated find_workload_path to detect this correctly. Co-Authored-By: Claude <noreply@anthropic.com> * Address PR review security and robustness issues Security fixes: - Escape executable path in cmd_run to prevent shell injection - Add workload name validation to cmd_analyze and cmd_compare Robustness improvements: - Add error checking for uv package manager installation - Use consistent project root detection (find_project_root || get_project_root) - Use /opt/rocm instead of hardcoded /opt/rocm-7.0.1 in Docker mode - Derive ROCM_REQUIREMENTS path from ROCPROF_BIN for flexibility - Use gfx950 as fallback GPU consistent with common.sh Documentation updates: - Fix env var name GPU_TARGET -> CK_GPU_TARGET - Update storage layout to reflect current structure (workloads/<name>/) - Document clean and status commands - Clarify native vs Docker default paths Co-Authored-By: Claude <noreply@anthropic.com> * Simplify ck-rocprof to native-only mode Remove Docker mode from ck-rocprof. Docker users should run the tool via `ck-docker exec ck-rocprof ...` instead. This simplification: - Removes ~210 lines of Docker-specific code - Eliminates mode detection complexity - Makes the script easier to maintain - Provides clearer error messages when rocprof-compute is not found The setup command now lists all searched locations when rocprof-compute is not found, helping users understand how to install it. Co-Authored-By: Claude <noreply@anthropic.com> * Add rocprofiler-compute source installation fallback When rocprof-compute is not found in system locations, automatically install rocprofiler-compute 3.4.0 from source as a fallback. This eliminates the hard dependency on system ROCm packages. Implementation details: - Clone rocprofiler-compute from GitHub to ~/.local/ - Install dependencies via requirements.txt (not editable install) - Create wrapper that sets PYTHONPATH to source directory - Execute source script directly rather than importing as module This approach matches the project's development workflow and works around the incomplete pyproject.toml that prevents editable installs. Co-Authored-By: Claude <noreply@anthropic.com> --------- Co-authored-by: Claude <noreply@anthropic.com>
232 lines
6.0 KiB
Bash
Executable File
232 lines
6.0 KiB
Bash
Executable File
#!/bin/bash
|
|
# Copyright (c) Advanced Micro Devices, Inc., or its affiliates.
|
|
# SPDX-License-Identifier: MIT
|
|
|
|
# CK Test - Run Composable Kernel tests
|
|
# Environment-agnostic: works natively on ROCm hosts or inside containers
|
|
|
|
set -e
|
|
set -o pipefail
|
|
|
|
# Find script directory and load common utilities
|
|
SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
|
|
source "${SCRIPT_DIR}/common.sh"
|
|
|
|
# Initialize configuration
|
|
PROJECT_ROOT=$(find_project_root "${SCRIPT_DIR}" || get_project_root "${SCRIPT_DIR}")
|
|
BUILD_DIR=$(get_build_dir "${PROJECT_ROOT}")
|
|
|
|
# Help message
|
|
show_help() {
|
|
cat << EOF
|
|
CK Test - Run Composable Kernel tests
|
|
|
|
Usage: ck-test [options] [test_name] [-- gtest_options]
|
|
|
|
Options:
|
|
-h, --help Show this help message
|
|
--build-dir <dir> Build directory (default: ./build)
|
|
--no-build Skip building, run test directly
|
|
--list List available tests
|
|
--smoke Run all smoke tests (via CTest -L SMOKE_TEST)
|
|
--regression Run all regression tests (via CTest -L REGRESSION_TEST)
|
|
--all Run all tests (via CTest)
|
|
--filter <pattern> Shorthand for --gtest_filter=<pattern>
|
|
|
|
Arguments:
|
|
test_name Name of test executable (optional for --smoke/--regression/--all)
|
|
gtest_options Additional options passed to test (after --)
|
|
|
|
Environment:
|
|
CK_BUILD_DIR - Override build directory
|
|
|
|
Examples:
|
|
ck-test test_amdgcn_mma # Build and run specific test
|
|
ck-test test_amdgcn_mma --filter '*Fp16*' # Run with gtest filter
|
|
ck-test test_amdgcn_mma -- --gtest_filter=*Fp16* # Explicit gtest options
|
|
ck-test --no-build test_amdgcn_mma # Run without rebuilding
|
|
ck-test --list # List available tests
|
|
ck-test --smoke # Run all smoke tests
|
|
ck-test --regression # Run all regression tests
|
|
ck-test --all # Run all tests
|
|
|
|
EOF
|
|
}
|
|
|
|
# Parse arguments
|
|
test_name=""
|
|
no_build=false
|
|
list_tests=false
|
|
run_smoke=false
|
|
run_regression=false
|
|
run_all=false
|
|
gtest_filter=""
|
|
gtest_options=()
|
|
parsing_gtest=false
|
|
|
|
while [[ $# -gt 0 ]]; do
|
|
if [ "$parsing_gtest" = true ]; then
|
|
gtest_options+=("$1")
|
|
shift
|
|
continue
|
|
fi
|
|
|
|
case $1 in
|
|
-h|--help)
|
|
show_help
|
|
exit 0
|
|
;;
|
|
--build-dir)
|
|
require_arg "$1" "${2:-}"
|
|
BUILD_DIR="$2"
|
|
shift 2
|
|
;;
|
|
--no-build)
|
|
no_build=true
|
|
shift
|
|
;;
|
|
--list)
|
|
list_tests=true
|
|
shift
|
|
;;
|
|
--smoke)
|
|
run_smoke=true
|
|
shift
|
|
;;
|
|
--regression)
|
|
run_regression=true
|
|
shift
|
|
;;
|
|
--all)
|
|
run_all=true
|
|
shift
|
|
;;
|
|
--filter)
|
|
require_arg "$1" "${2:-}"
|
|
gtest_filter="$2"
|
|
shift 2
|
|
;;
|
|
--)
|
|
parsing_gtest=true
|
|
shift
|
|
;;
|
|
--gtest_*)
|
|
gtest_options+=("$1")
|
|
shift
|
|
;;
|
|
*)
|
|
if [ -z "$test_name" ]; then
|
|
test_name="$1"
|
|
else
|
|
gtest_options+=("$1")
|
|
fi
|
|
shift
|
|
;;
|
|
esac
|
|
done
|
|
|
|
# Add filter to gtest options if specified
|
|
if [ -n "$gtest_filter" ]; then
|
|
gtest_options+=("--gtest_filter=${gtest_filter}")
|
|
fi
|
|
|
|
# Validate mutual exclusivity of test suite options
|
|
suite_count=0
|
|
[ "$run_smoke" = true ] && suite_count=$((suite_count + 1))
|
|
[ "$run_regression" = true ] && suite_count=$((suite_count + 1))
|
|
[ "$run_all" = true ] && suite_count=$((suite_count + 1))
|
|
|
|
if [ "$suite_count" -gt 1 ]; then
|
|
error "Options --smoke, --regression, and --all are mutually exclusive"
|
|
exit 1
|
|
fi
|
|
|
|
# Check build is configured
|
|
if ! is_build_configured "${BUILD_DIR}"; then
|
|
error "Build not configured. Run 'ck-configure' first"
|
|
exit 1
|
|
fi
|
|
|
|
# Handle --list
|
|
if [ "$list_tests" = true ]; then
|
|
info "Available tests:"
|
|
if [ -d "${BUILD_DIR}/bin" ]; then
|
|
ls -1 "${BUILD_DIR}/bin/" 2>/dev/null | grep -E '^test_' | sort || echo " (No test binaries found)"
|
|
else
|
|
echo " (No bin directory found)"
|
|
fi
|
|
echo ""
|
|
echo "CTest labels:"
|
|
cd "${BUILD_DIR}"
|
|
ctest -N 2>/dev/null | head -20 || echo " (Run 'ctest -N' for full list)"
|
|
exit 0
|
|
fi
|
|
|
|
# Handle CTest-based test suites
|
|
if [ "$run_smoke" = true ] || [ "$run_regression" = true ] || [ "$run_all" = true ]; then
|
|
cd "${BUILD_DIR}"
|
|
|
|
ctest_cmd=(ctest --output-on-failure)
|
|
|
|
if [ "$run_smoke" = true ]; then
|
|
ctest_cmd+=(-L SMOKE_TEST)
|
|
info "Running smoke tests..."
|
|
elif [ "$run_regression" = true ]; then
|
|
ctest_cmd+=(-L REGRESSION_TEST)
|
|
info "Running regression tests..."
|
|
else
|
|
info "Running all tests..."
|
|
fi
|
|
|
|
"${ctest_cmd[@]}"
|
|
exit_code=$?
|
|
|
|
echo ""
|
|
if [ $exit_code -eq 0 ]; then
|
|
info "Tests completed successfully"
|
|
else
|
|
error "Tests failed with exit code: ${exit_code}"
|
|
fi
|
|
exit $exit_code
|
|
fi
|
|
|
|
# Validate test name for individual test runs
|
|
if [ -z "$test_name" ]; then
|
|
error "test_name required (or use --smoke/--regression/--all for test suites)"
|
|
echo ""
|
|
show_help
|
|
exit 1
|
|
fi
|
|
|
|
# Build test if needed (unless --no-build is specified)
|
|
if [ "$no_build" = false ]; then
|
|
info "Building ${test_name}..."
|
|
"${SCRIPT_DIR}/ck-build" --build-dir "${BUILD_DIR}" "${test_name}"
|
|
echo ""
|
|
fi
|
|
|
|
# Verify test executable exists
|
|
test_binary="${BUILD_DIR}/bin/${test_name}"
|
|
if [ ! -f "$test_binary" ]; then
|
|
error "Test executable not found: ${test_binary}"
|
|
echo "Run 'ck-build ${test_name}' first"
|
|
exit 1
|
|
fi
|
|
|
|
# Run test
|
|
echo "Running: ${test_name} ${gtest_options[*]}"
|
|
echo "---"
|
|
|
|
cd "${BUILD_DIR}"
|
|
"./bin/${test_name}" "${gtest_options[@]}"
|
|
exit_code=$?
|
|
|
|
echo "---"
|
|
if [ $exit_code -eq 0 ]; then
|
|
info "Test completed successfully"
|
|
else
|
|
error "Test failed with exit code: ${exit_code}"
|
|
fi
|
|
|
|
exit $exit_code
|