mirror of
https://github.com/ROCm/composable_kernel.git
synced 2026-05-12 01:10:17 +00:00
7d6c8e5afa
[CK] [CK Tile] Improved ci_safety_check in smart-build infrastructure (#6215) ## Motivation The two-dot syntax (origin/develop..HEAD) is more conservative and catches a broader set of changes when PRs merge develop branch. While three-dot syntax shows only PR-specific changes, two-dot ensures we don't miss any files that differ between develop and the PR branch, including files modified in both the PR and merged develop commits. This conservative approach prioritizes catching all potential issues over CI efficiency, which is appropriate for build system change detection. # Technical Details: - Switched to two-dot (..) syntax in ci_safety_check.sh - Update comments to clarify the intentional use of two-dot syntax - Maintain consistency across both CHANGE_ID branches - Trigger full build when any of the following changes - `Dockerfile|Jenkinsfile|CMakePresets\.json|script/dependency-parser/` ## Test Plan Tested with PR 6200 which has multiple merge-commits. ## Test Result It detects 43 new tests compared to 3-dot scheme. ## Submission Checklist - [x ] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.
118 lines
4.8 KiB
Bash
Executable File
118 lines
4.8 KiB
Bash
Executable File
#!/bin/bash
|
|
# Copyright (c) Advanced Micro Devices, Inc., or its affiliates.
|
|
# SPDX-License-Identifier: MIT
|
|
|
|
# CI Safety Check for Smart Build System
|
|
#
|
|
# This script determines when to force full builds vs selective builds.
|
|
# Integrates with existing Jenkins infrastructure (FORCE_CI, BRANCH_NAME, etc.)
|
|
#
|
|
# Exit codes:
|
|
# 0 = Selective build OK (use smart build)
|
|
# 1 = Full build required
|
|
#
|
|
# Environment variables (set by Jenkins):
|
|
# FORCE_CI - Set to "true" for nightly/scheduled builds
|
|
# BRANCH_NAME - Git branch name
|
|
# CHANGE_ID - PR number (set by Jenkins Multibranch Pipeline for PRs)
|
|
# CHANGE_TARGET - Base branch for PR builds (set by Jenkins Multibranch Pipeline)
|
|
#
|
|
# Note: CHANGE_ID may not be set even for PR builds if Jenkins job is not
|
|
# configured as Multibranch Pipeline. Script uses two-dot git diff syntax
|
|
# to detect PR changes regardless of CHANGE_ID availability.
|
|
#
|
|
# Manual override (set by developer/admin if needed):
|
|
# DISABLE_SMART_BUILD - Set to "true" to force full build
|
|
# BASE_BRANCH - Override base branch (default: "develop")
|
|
|
|
set -e
|
|
|
|
# Configuration
|
|
FORCE_FULL_BUILD=false
|
|
REASON=""
|
|
BASE_BRANCH="${CHANGE_TARGET:-${BASE_BRANCH:-develop}}"
|
|
|
|
# 1. Check if this is a nightly/scheduled build
|
|
# Existing Jenkins infrastructure sets FORCE_CI=true for cron-triggered builds
|
|
if [ "$FORCE_CI" = "true" ]; then
|
|
FORCE_FULL_BUILD=true
|
|
REASON="nightly/scheduled build (FORCE_CI=true from Jenkins cron)"
|
|
fi
|
|
|
|
# 2. Manual override to disable smart build
|
|
# Set DISABLE_SMART_BUILD=true in Jenkins job parameters if you want to force a full build
|
|
if [ "$DISABLE_SMART_BUILD" = "true" ]; then
|
|
FORCE_FULL_BUILD=true
|
|
REASON="manual override (DISABLE_SMART_BUILD=true)"
|
|
fi
|
|
|
|
# 3. Force full build if CMakeLists.txt or cmake/ configuration changed
|
|
# Always compare against base branch (not consecutive commits) to avoid false positives from merge commits
|
|
# Two-dot syntax (..) compares current state against base branch
|
|
# Note: This includes merged changes from develop, which is conservative but safe (catches all potentially affected files)
|
|
CHANGED_FILES=$(git diff --name-only origin/${BASE_BRANCH}..HEAD 2>/dev/null || echo "")
|
|
|
|
# Comprehensive pattern for build/infrastructure files that require full build:
|
|
# - CMake: CMakeLists.txt, *.cmake, *.cmake.in, CMakePresets.json
|
|
# - Docker: Dockerfile*, docker-compose*
|
|
# - CI/CD: Jenkinsfile, .github/, .gitlab-ci.yml, .pre-commit-config.yaml, .readthedocs.yaml
|
|
# - Scripts: script/ directory (cmake, dependency-parser, build utilities)
|
|
# - Compiler: .clang-format, .clang-tidy
|
|
# - Python: setup.py, pyproject.toml, requirements*.txt
|
|
BUILD_INFRA_PATTERN="(CMakeLists\.txt"
|
|
BUILD_INFRA_PATTERN="${BUILD_INFRA_PATTERN}|\.cmake$|\.cmake\.in$|CMakePresets\.json"
|
|
BUILD_INFRA_PATTERN="${BUILD_INFRA_PATTERN}|Dockerfile|docker-compose"
|
|
BUILD_INFRA_PATTERN="${BUILD_INFRA_PATTERN}|Jenkinsfile|\.github/|\.gitlab-ci\.yml"
|
|
BUILD_INFRA_PATTERN="${BUILD_INFRA_PATTERN}|\.pre-commit-config\.yaml|\.readthedocs\.yaml"
|
|
BUILD_INFRA_PATTERN="${BUILD_INFRA_PATTERN}|script/"
|
|
BUILD_INFRA_PATTERN="${BUILD_INFRA_PATTERN}|\.clang-format|\.clang-tidy"
|
|
BUILD_INFRA_PATTERN="${BUILD_INFRA_PATTERN}|setup\.py|pyproject\.toml|requirements.*\.txt)"
|
|
|
|
if echo "$CHANGED_FILES" | grep -qE "${BUILD_INFRA_PATTERN}"; then
|
|
FORCE_FULL_BUILD=true
|
|
REASON="build system configuration changed"
|
|
fi
|
|
|
|
# 4. Force full build if dependency cache is older than 7 days
|
|
CACHE_FILE="cmake_dependency_mapping.json"
|
|
if [ -f "$CACHE_FILE" ]; then
|
|
# Different stat command for Linux vs macOS
|
|
if [[ "$OSTYPE" == "darwin"* ]]; then
|
|
CACHE_MTIME=$(stat -f %m "$CACHE_FILE")
|
|
else
|
|
CACHE_MTIME=$(stat -c %Y "$CACHE_FILE")
|
|
fi
|
|
CURRENT_TIME=$(date +%s)
|
|
CACHE_AGE_DAYS=$(( ($CURRENT_TIME - $CACHE_MTIME) / 86400 ))
|
|
|
|
if [ $CACHE_AGE_DAYS -gt 7 ]; then
|
|
FORCE_FULL_BUILD=true
|
|
REASON="dependency cache older than 7 days"
|
|
fi
|
|
fi
|
|
|
|
# Output decision
|
|
echo "========================================="
|
|
echo "Smart Build Safety Check"
|
|
echo "========================================="
|
|
echo "FORCE_CI: ${FORCE_CI:-false}"
|
|
echo "BRANCH_NAME: ${BRANCH_NAME:-unknown}"
|
|
echo "BASE_BRANCH: ${BASE_BRANCH}"
|
|
echo "CHANGE_ID: ${CHANGE_ID:-<not a PR>}"
|
|
echo "DISABLE_SMART_BUILD: ${DISABLE_SMART_BUILD:-false}"
|
|
echo "-----------------------------------------"
|
|
|
|
if [ "$FORCE_FULL_BUILD" = true ]; then
|
|
echo "Decision: 🔴 FULL BUILD REQUIRED"
|
|
echo "Reason: $REASON"
|
|
echo "========================================="
|
|
echo "export SMART_BUILD_MODE=full" > build_mode.env
|
|
exit 1 # Exit with error to signal full build needed
|
|
else
|
|
echo "Decision: 🟢 SELECTIVE BUILD ENABLED"
|
|
echo "Using smart build for faster CI"
|
|
echo "========================================="
|
|
echo "export SMART_BUILD_MODE=selective" > build_mode.env
|
|
exit 0 # Exit success to signal selective build OK
|
|
fi
|