mirror of
https://github.com/ROCm/composable_kernel.git
synced 2026-05-04 05:31:24 +00:00
280bc42191
Refactor the builder factory code into multiple files and subdirectories and a ck_tile::builder::factory namespace. The factory implements compile-time dispatch from high-level signature and algorithm descriptors to our existing specialized convolution kernel implementations. Major changes in this PR: Dispatch logic is explicit in the function make_conv_instance instead of implicit in template specialization selection. Helper code is moved to a subdirectory builder/factory/helpers. Helpers now have unit tests. Factories are moved to their own files. Code moved to namespaces ck_tile::builder::factory and ck_tile::builder::factory::internal. This does not yet fix the problem of bad error messages, but the make_conv_instance function makes the poor error messages clear. The choice of algorithm must be much more robust (perhaps with explicit enumeration in the algorithm descriptor), so that the dispatch doesn't fail. Quality changes: Making dispatch explicit rather than implicit will improve robustness, readability, maintainability, testability, and extensibility. Separating code into separate files and subdirectories helps readability and extensibility. Adding unit tests for helpers documents behavior and will enable more complex logic and functionality. Separating files (especially unit tests) helps clarify includes and dependencies and makes code easier to refactor.
38 lines
1.4 KiB
C++
38 lines
1.4 KiB
C++
// Copyright (c) Advanced Micro Devices, Inc., or its affiliates.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
#pragma once
|
|
|
|
#include <concepts>
|
|
#include <type_traits>
|
|
|
|
#include "ck_tile/builder/factory/conv_dispatcher.hpp"
|
|
#include "ck_tile/builder/versions.hpp"
|
|
|
|
namespace ck_tile::builder {
|
|
|
|
/**
|
|
* @brief Top-level builder for creating convolution kernel instances.
|
|
*
|
|
* This struct serves as the main entry point for generating a convolution kernel.
|
|
* It uses a dispatcher function based on the provided signature, algorithm, and version
|
|
* to construct the appropriate kernel instance.
|
|
*
|
|
* @tparam SIGNATURE The convolution signature, which describes the mathematical functionality of
|
|
* the algorithm (e.g., data types, layouts, direction).
|
|
* @tparam ALGORITHM The specific convolution algorithm to be used for the implementation.
|
|
* @tparam VERSION The version of the builder implementation.
|
|
*/
|
|
template <ConvSignatureDescriptor auto SIGNATURE,
|
|
ConvAlgorithmDescriptor auto ALGORITHM,
|
|
StringLiteral VERSION = LATEST_API_VERSION>
|
|
requires SupportedVersion<VERSION> && ValidConvSignature<SIGNATURE>
|
|
struct ConvBuilder
|
|
{
|
|
static constexpr auto kVersion = VERSION;
|
|
// Output: The kernel class instance created via the dispatcher.
|
|
using Instance = decltype(factory::make_conv_instance<SIGNATURE, ALGORITHM, VERSION>());
|
|
};
|
|
|
|
} // namespace ck_tile::builder
|