mirror of
https://github.com/ROCm/composable_kernel.git
synced 2026-06-11 08:48:45 +00:00
[ck] Enforce ASCII-only C/C++ sources for hipRTC compatibility (#7829) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ## Summary CK source files must be compilable via **hipRTC (HIP runtime compilation)**, whose preprocessor does not accept non-ASCII bytes anywhere in a translation unit — **including in comments**. Bytes that are harmless under `hipcc` (em-dashes, smart quotes, multiplication signs, Greek letters, box-drawing glyphs, etc.) cause hipRTC to fail at preprocessing time. These regularly leak in via LLM-assisted authoring or copy/paste from formatted documents and silently break hipRTC paths that are not exercised by the default `hipcc`-based build matrix. This PR (a) cleans every existing violation (53 files) and (b) adds a pre-checkin gate so new violations are rejected before merge. ## File extensions covered Both the cleanup scan and the new Jenkins enforcement stage use the same predicate: ``` *.h *.hpp *.cpp *.h.in *.hpp.in *.cpp.in *.inc *.cl ``` (excluding `*/build/*` and `*/include/rapidjson/*`). This is a strict superset of the existing `Clang Format` stage's predicate — `*.inc` is added so test-fixture include files are also gated. The local pre-commit hook's `c++/inc` type filter covers the same set. ## Why no enforcement today CK is opted out of the rocm-libraries root `.pre-commit-config.yaml`, so the existing `pre-commit` workflow doesn't touch CK. The local CK `.pre-commit-config.yaml` only runs for developers who installed hooks. The **authoritative gate is therefore the new Jenkins stage** in this PR; the local hook is convenience. ## Commit layout (bisect-friendly) 1. `79798aa6261` — **`[ck] Convert reflect/ rendering to ASCII for hipRTC compatibility`** Behavior change, isolated. `TreeFormatter` swaps `├─ / └─ / │ ` for `|- / +- / | ` (3-col width preserved so alignment is unchanged). `conv_description.hpp` swaps `×` for `x` as the dimension separator. `test_conv_description.cpp` expected strings updated in lockstep so the snapshot test stays green. This is the only commit in the series with observable runtime impact. 2. `738fdb0d81c` — **`[ck] Strip non-ASCII bytes from C++ sources for hipRTC compatibility`** Mechanical text cleanup across 53 files. Replacements happen in comments or in `std::cout` strings that are not asserted on by any test. None of the 174 `.inc` files in the tree required edits, but they were in the scan's predicate so the enforcement stage's predicate is a superset of what was scanned. Full replacement table in the commit message. 3. `1d7cd8ba235` — **`[ck] Enforce ASCII-only C/C++ sources for hipRTC compatibility`** - New `projects/composablekernel/script/check_ascii_only.sh` (modeled on `check_copyright_year.sh`). - New entry in `projects/composablekernel/.pre-commit-config.yaml` under the local-hooks block (`types_or: [c++, inc]`). - New `ASCII Only Check` parallel stage in `projects/composablekernel/Jenkinsfile`'s `Static checks` block, mirroring the existing `Clang Format` stage but with `*.inc` added to the find predicate. Always-on, no `RUN_CPPCHECK` gate. The tree is buildable at every commit boundary. Commit 1 leaves 50 known violations; commit 2 leaves 0; commit 3 wires the gate. ## Demo Script output on a synthesized violation: ``` $ printf '// em-dash test \xe2\x80\x94 here\n' > /tmp/bad.cpp $ projects/composablekernel/script/check_ascii_only.sh /tmp/bad.cpp ERROR: /tmp/bad.cpp contains non-ASCII bytes: 1:// em-dash test — here Fix: replace with ASCII (em-dash -> --, smart quotes -> ", arrows -> ->, etc.) $ echo $? 1 ``` Full repo scan after the cleanup commits (note the `-name '*.inc'` clause): ``` $ cd projects/composablekernel && find . -type f \( -name '*.h' -o -name '*.hpp' -o -name '*.cpp' \ -o -name '*.h.in' -o -name '*.hpp.in' -o -name '*.cpp.in' -o -name '*.inc' -o -name '*.cl' \) \ -not -path '*/build/*' -not -path '*/include/rapidjson/*' -print0 \ | xargs -0 -P 8 -n 64 script/check_ascii_only.sh $ echo $? 0 ``` ## Test plan - [ ] Jenkins PR build: confirm new `Static checks -> ASCII Only Check` stage runs green over the full predicate (incl. `*.inc`) and existing `Clang Format` stage is unaffected. - [ ] `test_conv_description` passes against the ASCII tree-formatter output (touched in commit 1). - [ ] Local: `pre-commit run ascii-only-checker --all-files` runs cleanly after installing CK pre-commit hooks via `script/install_precommit.sh`. - [ ] Manually inject a non-ASCII byte in any `.cpp/.hpp/.inc` file, push: confirm Jenkins fails the new stage with a clear error. - [ ] Spot-check a representative subset of touched files under hipRTC compilation to confirm no remaining hipRTC-blocking content (optional, since the static byte check is a sufficient condition for hipRTC preprocessor acceptance on this dimension). 🤖 Generated with [Claude Code](https://claude.com/claude-code)
126 lines
4.5 KiB
C++
126 lines
4.5 KiB
C++
// Copyright (c) Advanced Micro Devices, Inc., or its affiliates.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
#pragma once
|
|
|
|
#include "ck_tile/core.hpp"
|
|
#include "ck_tile/host/host_tensor.hpp"
|
|
#include <thread>
|
|
#include <numeric>
|
|
#include <functional>
|
|
#include <utility>
|
|
#include <algorithm>
|
|
|
|
namespace ck_tile {
|
|
|
|
/*
|
|
similiar to torch.topk()
|
|
x (Tensor) - the input tensor.
|
|
k (int) - the k in "top-k"
|
|
dim (int, optional) - the dimension to sort along
|
|
largest (bool, optional) - largest or smallest elements
|
|
sorted (bool, optional) - elements in sorted order or not
|
|
|
|
output:
|
|
y_values
|
|
y_indices
|
|
|
|
https://github.com/pytorch/pytorch/blob/main/aten/src/ATen/native/TopKImpl.h
|
|
*/
|
|
template <typename DataType, typename IndexType = index_t>
|
|
CK_TILE_HOST void reference_topk(const HostTensor<DataType>& x,
|
|
HostTensor<DataType>& y_values,
|
|
HostTensor<IndexType>& y_indices,
|
|
index_t k,
|
|
index_t dim = -1,
|
|
bool largest = true,
|
|
bool sorted = true)
|
|
{
|
|
// rank must be the same
|
|
index_t rank = x.get_num_of_dimension();
|
|
assert(static_cast<std::size_t>(rank) == y_values.get_num_of_dimension());
|
|
assert(static_cast<size_t>(rank) == y_indices.get_num_of_dimension());
|
|
assert(dim == -1 || dim < rank);
|
|
|
|
index_t topk_dim = dim == -1 ? (rank - 1) : dim;
|
|
index_t topk_src_len = x.get_length(topk_dim);
|
|
auto x_len = x.get_lengths();
|
|
|
|
assert(k <= topk_src_len);
|
|
assert(static_cast<size_t>(k) == y_values.get_length(topk_dim) &&
|
|
static_cast<size_t>(k) == y_indices.get_length(topk_dim));
|
|
|
|
index_t n_parallel = x.get_element_size() / topk_src_len;
|
|
|
|
// clang-format off
|
|
auto f = [&](auto i_element) {
|
|
std::vector<size_t> topk_coord = [&](){
|
|
std::vector<size_t> t_(rank, 0);
|
|
size_t r = i_element;
|
|
for(index_t i = rank - 1; i >= 0; i--) {
|
|
if(i == topk_dim) continue; // topk dim should be zero
|
|
t_[i] = r % x_len[i]; r = r / x_len[i];
|
|
}
|
|
return t_;
|
|
}();
|
|
|
|
using elem_t = std::pair<DataType, IndexType>;
|
|
std::vector<elem_t> q = [&](){
|
|
std::vector<elem_t> t_(topk_src_len);
|
|
for(index_t i = 0; i < topk_src_len; i++) {
|
|
auto c_ = topk_coord; c_[topk_dim] = i;
|
|
t_[i].first = x(c_); t_[i].second = i;
|
|
}
|
|
return t_;
|
|
}();
|
|
|
|
// run topk
|
|
if(largest) {
|
|
std::nth_element(q.begin(), q.begin() + k - 1, q.end(),
|
|
[](const elem_t& lhs, const elem_t& rhs) -> bool { return lhs.first > rhs.first; });
|
|
if(sorted) {
|
|
std::sort(q.begin(), q.begin() + k - 1,
|
|
[](const elem_t& lhs, const elem_t& rhs) -> bool { return lhs.first > rhs.first; });
|
|
}
|
|
} else {
|
|
std::nth_element(q.begin(), q.begin() + k - 1, q.end(),
|
|
[](const elem_t& lhs, const elem_t& rhs) -> bool { return lhs.first < rhs.first; });
|
|
if(sorted) {
|
|
std::sort(q.begin(), q.begin() + k - 1,
|
|
[](const elem_t& lhs, const elem_t& rhs) -> bool { return lhs.first < rhs.first; });
|
|
}
|
|
}
|
|
|
|
// write out
|
|
for(index_t i = 0; i < k; i++) {
|
|
auto c_ = topk_coord; c_[topk_dim] = i;
|
|
y_values(c_) = q[i].first; y_indices(c_) = q[i].second;
|
|
}
|
|
};
|
|
// clang-format on
|
|
|
|
make_ParallelTensorFunctor(f, n_parallel)(std::thread::hardware_concurrency());
|
|
}
|
|
|
|
// TODO: if using this method, the return tensor would be dense(no stride)
|
|
template <typename DataType, typename IndexType = index_t>
|
|
CK_TILE_HOST auto reference_topk(const HostTensor<DataType>& x,
|
|
index_t k,
|
|
index_t dim = -1,
|
|
bool largest = true,
|
|
bool sorted = true)
|
|
{
|
|
auto lens = x.get_lengths();
|
|
index_t target_dim = (dim == -1) ? (lens.size() - 1) : dim;
|
|
assert(target_dim < lens.size());
|
|
assert(k <= lens[target_dim]);
|
|
lens[target_dim] = k;
|
|
HostTensor<DataType> y_values(lens);
|
|
HostTensor<IndexType> y_indices(lens);
|
|
|
|
reference_topk<DataType, IndexType>(x, y_values, y_indices, k, dim, largest, sorted);
|
|
|
|
return ck_tile::make_tuple(y_values, y_indices);
|
|
}
|
|
} // namespace ck_tile
|