mirror of
https://github.com/ROCm/composable_kernel.git
synced 2026-05-12 01:10:17 +00:00
7613c1d9b9
incomplete fix from https://github.com/ROCmSoftwarePlatform/composable_kernel/pull/670 So it does not only happen in gtest but also in CK code: We need to fix them as a quality improvement, but for now suppressing this warning in immediate releases: http://compiler-ci.amd.com/blue/rest/organizations/jenkins/pipelines/compiler-psdb-amd-stg-open/runs/2540/nodes/282/steps/3202/log/?start=0 e.g. ``` [2023-04-26T17:26:31.524Z] /jenkins/workspace/compiler-psdb-amd-stg-open/Libs/MIOpen/deps_hip/cget/build/tmp-a3db5da587a64213bde99fb856db1b43/composable_kernel-0f98035df1cc5ba3e90ab03187e672b426a25b00/include/ck/utility/generic_memory_space_atomic.hpp:52:19: error: unsafe pointer arithmetic [-Werror,-Wunsafe-buffer-usage] [2023-04-26T17:26:31.524Z] atomicAdd(c_style_pointer_cast<float*>(p_dst) + 1, vx.template AsType<float>()[I1]); [2023-04-26T17:26:31.524Z] ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ``` ``` [2023-04-26T17:26:31.523Z] /jenkins/workspace/compiler-psdb-amd-stg-open/Libs/MIOpen/deps_hip/cget/build/tmp-a3db5da587a64213bde99fb856db1b43/composable_kernel-0f98035df1cc5ba3e90ab03187e672b426a25b00/include/ck/utility/amd_inline_asm.hpp:62:20: error: 'p_a_half2' is an unsafe pointer used for buffer access [-Werror,-Wunsafe-buffer-usage] [2023-04-26T17:26:31.523Z] const half2_t* p_a_half2 = c_style_pointer_cast<const half2_t*>(&a); [2023-04-26T17:26:31.523Z] ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ```
113 lines
4.2 KiB
CMake
113 lines
4.2 KiB
CMake
################################################################################
|
|
#
|
|
# MIT License
|
|
#
|
|
# Copyright (c) 2017 Advanced Micro Devices, Inc.
|
|
#
|
|
# Permission is hereby granted, free of charge, to any person obtaining a copy
|
|
# of this software and associated documentation files (the "Software"), to deal
|
|
# in the Software without restriction, including without limitation the rights
|
|
# to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
# copies of the Software, and to permit persons to whom the Software is
|
|
# furnished to do so, subject to the following conditions:
|
|
#
|
|
# The above copyright notice and this permission notice shall be included in all
|
|
# copies or substantial portions of the Software.
|
|
#
|
|
# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
# FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
|
|
# AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
|
# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
|
|
# SOFTWARE.
|
|
#
|
|
################################################################################
|
|
# - Enable warning all for gcc/clang or use /W4 for visual studio
|
|
|
|
## Strict warning level
|
|
if (MSVC)
|
|
# Use the highest warning level for visual studio.
|
|
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /w")
|
|
set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} /w")
|
|
# set(CMAKE_CXX_WARNING_LEVEL 4)
|
|
# if (CMAKE_CXX_FLAGS MATCHES "/W[0-4]")
|
|
# string(REGEX REPLACE "/W[0-4]" "/W4" CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS}")
|
|
# else ()
|
|
# set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /W4")
|
|
# endif ()
|
|
|
|
# set(CMAKE_C_WARNING_LEVEL 4)
|
|
# if (CMAKE_C_FLAGS MATCHES "/W[0-4]")
|
|
# string(REGEX REPLACE "/W[0-4]" "/W4" CMAKE_C_FLAGS "${CMAKE_C_FLAGS}")
|
|
# else ()
|
|
# set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} /W4")
|
|
# endif ()
|
|
|
|
else()
|
|
foreach(COMPILER C CXX)
|
|
set(CMAKE_COMPILER_WARNINGS)
|
|
# use -Wall for gcc and clang
|
|
list(APPEND CMAKE_COMPILER_WARNINGS
|
|
-Wall
|
|
-Wextra
|
|
-Wcomment
|
|
-Wendif-labels
|
|
-Wformat
|
|
-Winit-self
|
|
-Wreturn-type
|
|
-Wsequence-point
|
|
# Shadow is broken on gcc when using lambdas
|
|
# -Wshadow
|
|
-Wswitch
|
|
-Wtrigraphs
|
|
-Wundef
|
|
-Wuninitialized
|
|
-Wunreachable-code
|
|
-Wunused
|
|
-Wno-reserved-identifier
|
|
-Werror
|
|
-Wsign-compare
|
|
-Wno-extra-semi-stmt
|
|
)
|
|
if (CMAKE_${COMPILER}_COMPILER_ID MATCHES "Clang")
|
|
list(APPEND CMAKE_COMPILER_WARNINGS
|
|
-Weverything
|
|
-Wno-c++98-compat
|
|
-Wno-c++98-compat-pedantic
|
|
-Wno-conversion
|
|
-Wno-double-promotion
|
|
-Wno-exit-time-destructors
|
|
-Wno-extra-semi
|
|
-Wno-float-conversion
|
|
-Wno-gnu-anonymous-struct
|
|
-Wno-gnu-zero-variadic-macro-arguments
|
|
-Wno-missing-prototypes
|
|
-Wno-nested-anon-types
|
|
-Wno-padded
|
|
-Wno-return-std-move-in-c++11
|
|
-Wno-shorten-64-to-32
|
|
-Wno-sign-conversion
|
|
-Wno-unknown-warning-option
|
|
-Wno-unused-command-line-argument
|
|
-Wno-weak-vtables
|
|
-Wno-covered-switch-default
|
|
-Wno-unsafe-buffer-usage
|
|
)
|
|
else()
|
|
if (CMAKE_${COMPILER}_COMPILER_ID MATCHES "GNU" AND ${COMPILER} MATCHES "CXX")
|
|
# cmake 3.5.2 does not support >=.
|
|
if(NOT CMAKE_CXX_COMPILER_VERSION VERSION_LESS "6.1")
|
|
list(APPEND CMAKE_COMPILER_WARNINGS
|
|
-Wno-ignored-attributes)
|
|
endif()
|
|
endif()
|
|
list(APPEND CMAKE_COMPILER_WARNINGS
|
|
-Wno-missing-field-initializers
|
|
-Wno-deprecated-declarations
|
|
)
|
|
endif()
|
|
add_definitions(${CMAKE_COMPILER_WARNINGS})
|
|
endforeach()
|
|
endif ()
|