[PR #43] [MERGED] Docker Fix dos unix malfunction in windows #58

New issue

Closed

opened 2026-10-20 09:53:33 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-20 09:53:33 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/RVC-Project/Retrieval-based-Voice-Conversion/pull/43
Author: @FYYHU
Created: 9/3/2024
Status: ✅ Merged
Merged: 10/14/2024
Merged by: @Tps-F

Base: develop ← Head: develop

📝 Commits (1)

936e5db Docker Fix dos unix malfunction in windows

📊 Changes

1 file changed (+5 additions, -1 deletions)

View changed files

📝 Dockerfile (+5 -1)

📄 Description

Description

Docker image will not build when host is a Windows device. Problem is caused by malformed .sh script when the files are cloned to a windows device.

Type of change

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Test Windows cpu
Test Windows cuda
Test Linux cpu (needs to be checked)
Test Linux cuda (needs to be checked)
Testing procedure:

Used the following rvc model to test the api (https://huggingface.co/sail-rvc/Donald_Trump__RVC_v2_)
any valid speech file test.wav
For the non cuda tested using

docker run -it  -p 8000:8000 -v "{host_project_dir}/assets/weights:/weights" -v "{host_project_dir}/assets/indices:/indices" -v "{host_project_dir}/assets/audios:/audios" "rvc"

After running this copy the model.pth to the {host_project_dir}/assets/weights folder and model.index to {host_project_dir}/assets/indices. Finally copy your test.wav file to {host_project_dir}/assets/audios/test.wav
For the cuda test add --gpus=all to enable gpu usage.

docker run -it --gpus=all -p 8000:8000 -v "{host_project_dir}/assets/weights:/weights" -v "{host_project_dir}/assets/indices:/indices" -v "{host_project_dir}/assets/audios:/audios" "rvc"

Too save time I used the fastapi automatic documentation in it you have a button "try it" to quickely test if the inference api works.
Note for the audio path use the absolute path within the container to the audio file NOT the host path.

Test Configuration:

OS: Windows 11
Hardware: Intel cpu, nvidia quadro p2000

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/RVC-Project/Retrieval-based-Voice-Conversion/pull/43 **Author:** [@FYYHU](https://github.com/FYYHU) **Created:** 9/3/2024 **Status:** ✅ Merged **Merged:** 10/14/2024 **Merged by:** [@Tps-F](https://github.com/Tps-F) **Base:** `develop` ← **Head:** `develop` --- ### 📝 Commits (1) - [`936e5db`](https://github.com/RVC-Project/Retrieval-based-Voice-Conversion/commit/936e5db937a3592258feed05a187e473ff2389ff) Docker Fix dos unix malfunction in windows ### 📊 Changes **1 file changed** (+5 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `Dockerfile` (+5 -1) </details> ### 📄 Description ## Description Docker image will not build when host is a Windows device. Problem is caused by malformed .sh script when the files are cloned to a windows device. ## Type of change - [x] Bug fix (non-breaking change which fixes an issue) ## How Has This Been Tested? - [x] Test Windows cpu - [x] Test Windows cuda - [ ] Test Linux cpu (needs to be checked) - [ ] Test Linux cuda (needs to be checked) Testing procedure: * Used the following rvc model to test the api (https://huggingface.co/sail-rvc/Donald_Trump__RVC_v2_) * any valid speech file test.wav For the non cuda tested using ``` docker run -it -p 8000:8000 -v "{host_project_dir}/assets/weights:/weights" -v "{host_project_dir}/assets/indices:/indices" -v "{host_project_dir}/assets/audios:/audios" "rvc" ``` After running this copy the model.pth to the {host_project_dir}/assets/weights folder and model.index to {host_project_dir}/assets/indices. Finally copy your test.wav file to {host_project_dir}/assets/audios/test.wav For the cuda test add --gpus=all to enable gpu usage. ``` docker run -it --gpus=all -p 8000:8000 -v "{host_project_dir}/assets/weights:/weights" -v "{host_project_dir}/assets/indices:/indices" -v "{host_project_dir}/assets/audios:/audios" "rvc" ``` Too save time I used the fastapi automatic documentation in it you have a button "try it" to quickely test if the inference api works. Note for the audio path use the absolute path within the container to the audio file NOT the host path. **Test Configuration**: * OS: Windows 11 * Hardware: Intel cpu, nvidia quadro p2000 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-20 09:53:33 +00:00