SillyTavern/Extension-Live2d
1
0
Fork 0
mirror of https://github.com/SillyTavern/Extension-Live2d.git synced 2026-10-15 13:32:13 +00:00
Code Issues 8 Projects Packages Wiki Activity

[PR #2] [MERGED] Update index.min.js #10

New issue
Closed
opened 2026-10-15 13:25:55 +00:00 by bsakaguchi · 0 comments
bsakaguchi commented 2026-10-15 13:25:55 +00:00
Owner
Copy link

📋 Pull Request Information

Original PR: https://github.com/SillyTavern/Extension-Live2d/pull/2
Author: @Baromeus
Created: 12/24/2023
Status: ✅ Merged
Merged: 12/25/2023
Merged by: @Tony-sama

Base: main ← Head: EyeFocus

📝 Commits (1)

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 lib/index.min.js (+1 -1)

📄 Description

What was changed?
the offset of the y-variable inside focus() was changed from -1 to -0.45

What does it do?
the new offset will make the eyes the middle of the focus (before it was the middle of the whole model).
Now the Eyes follow the cursor better

Suggestion
While this new Value is good for most models I tested, it is not perfect, therefore it would be better to make this offset-variable changeable in the UI for each character.

Look at changes
Since this file is minimized the changes are obscure. To better see the change (just one number) format it, the change should be around row 977 (+/- differences by the formatter of your choosing)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/SillyTavern/Extension-Live2d/pull/2 **Author:** [@Baromeus](https://github.com/Baromeus) **Created:** 12/24/2023 **Status:** ✅ Merged **Merged:** 12/25/2023 **Merged by:** [@Tony-sama](https://github.com/Tony-sama) **Base:** `main` ← **Head:** `EyeFocus` --- ### 📝 Commits (1) - [`7c9530a`](https://github.com/SillyTavern/Extension-Live2d/commit/7c9530a73e8228e46390394a5746c79cdf30854c) Update index.min.js ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `lib/index.min.js` (+1 -1) </details> ### 📄 Description **What was changed?** the offset of the y-variable inside focus() was changed from -1 to -0.45 **What does it do?** the new offset will make the eyes the middle of the focus (before it was the middle of the whole model). Now the Eyes follow the cursor better **Suggestion** While this new Value is good for most models I tested, it is not perfect, therefore it would be better to make this offset-variable changeable in the UI for each character. **Look at changes** Since this file is minimized the changes are obscure. To better see the change (just one number) format it, the change should be around row 977 (+/- differences by the formatter of your choosing) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
bsakaguchi 2026-10-15 13:25:55 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
No results found.
Labels
Clear labels   
pull-request
Mirrored from GitHub Pull Request

No labels
pull-request
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
SillyTavern/Extension-Live2d#10
No description provided.