[PR #4] [MERGED] Update index.min.js - loading of .physics3.json #11

New issue

Closed

opened 2026-10-15 13:25:55 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-15 13:25:55 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/SillyTavern/Extension-Live2d/pull/4
Author: @Baromeus
Created: 12/25/2023
Status: ✅ Merged
Merged: 12/25/2023
Merged by: @Tony-sama

Base: main ← Head: physic-load

📝 Commits (1)

27a4256 Update index.min.js

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 lib/index.min.js (+1 -1)

📄 Description

changed loading routine for ".physics3.json"
(for now it tries to load a physics3.json instead and prompts a alternative warning if file is not found:

Originally I wanted to make it possible to load the dotted file and have this as fallback but my knowledge if JS is not good enough to provide a bulletproof method to check if a file exists (to my defense, minified code is awful to work with).

But with this users have a warning with a possible fix in it. Before they only got a 404 error with no explanation why and what they could do.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/SillyTavern/Extension-Live2d/pull/4 **Author:** [@Baromeus](https://github.com/Baromeus) **Created:** 12/25/2023 **Status:** ✅ Merged **Merged:** 12/25/2023 **Merged by:** [@Tony-sama](https://github.com/Tony-sama) **Base:** `main` ← **Head:** `physic-load` --- ### 📝 Commits (1) - [`27a4256`](https://github.com/SillyTavern/Extension-Live2d/commit/27a4256fb6bde56ac3431930b482f85f5c739752) Update index.min.js ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `lib/index.min.js` (+1 -1) </details> ### 📄 Description changed loading routine for ".physics3.json" (for now it tries to load a physics3.json instead and prompts a alternative warning if file is not found: ![image](https://github.com/SillyTavern/Extension-Live2d/assets/77576424/9c19bc24-f72f-4bd2-a5ce-6cd9b8fa6733) Originally I wanted to make it possible to load the dotted file and have this as fallback but my knowledge if JS is not good enough to provide a bulletproof method to check if a file exists (to my defense, minified code is awful to work with). But with this users have a warning with a possible fix in it. Before they only got a 404 error with no explanation why and what they could do. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-15 13:25:55 +00:00