[PR #8] [MERGED] Turn off the mic when switching providers #17

New issue

Closed

opened 2026-10-15 13:27:26 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-15 13:27:26 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/SillyTavern/Extension-Speech-Recognition/pull/8
Author: @Risenafis
Created: 7/12/2024
Status: ✅ Merged
Merged: 7/13/2024
Merged by: @Cohee1207

Base: main ← Head: stop-mic

📝 Commits (2)

4983c14 Turn off the mic when switching providers
5aa7f28 Stop the recording when switching to "None"

📊 Changes

2 files changed (+59 additions, -13 deletions)

View changed files

📝 browser.js (+10 -6)
📝 index.js (+49 -7)

📄 Description

When switching the provider while the microphone is in recording mode, the microphone display and recording status became inverted. I have fixed this by stopping the recording of the previous provider when loading a new provider.

I understand that the current microphone icon implementation indicates possible actions, but personally, I feel it is more natural to display the current recording status (similar to the display method in many messaging apps like Zoom and Teams).
That said, ChatGPT (Android app) is close to the current SillyTavern implementation, so I think there may be some demand for it (although it differs in that the big stop button is displayed separately and prominently at the bottom).
Still, I made the title toggle "Click to talk" / "Click to stop talking" so that it might be a bit clearer.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/SillyTavern/Extension-Speech-Recognition/pull/8 **Author:** [@Risenafis](https://github.com/Risenafis) **Created:** 7/12/2024 **Status:** ✅ Merged **Merged:** 7/13/2024 **Merged by:** [@Cohee1207](https://github.com/Cohee1207) **Base:** `main` ← **Head:** `stop-mic` --- ### 📝 Commits (2) - [`4983c14`](https://github.com/SillyTavern/Extension-Speech-Recognition/commit/4983c144c8112477a9a68902a99651cffd39691e) Turn off the mic when switching providers - [`5aa7f28`](https://github.com/SillyTavern/Extension-Speech-Recognition/commit/5aa7f28ea9c87370b31807ec8219f0c238609523) Stop the recording when switching to "None" ### 📊 Changes **2 files changed** (+59 additions, -13 deletions) <details> <summary>View changed files</summary> 📝 `browser.js` (+10 -6) 📝 `index.js` (+49 -7) </details> ### 📄 Description When switching the provider while the microphone is in recording mode, the microphone display and recording status became inverted. I have fixed this by stopping the recording of the previous provider when loading a new provider. I understand that the current microphone icon implementation indicates possible actions, but personally, I feel it is more natural to display the current recording status (similar to the display method in many messaging apps like Zoom and Teams). That said, ChatGPT (Android app) is close to the current SillyTavern implementation, so I think there may be some demand for it (although it differs in that the big stop button is displayed separately and prominently at the bottom). Still, I made the title toggle "Click to talk" / "Click to stop talking" so that it might be a bit clearer. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-15 13:27:26 +00:00