[PR #15] [CLOSED] Remove sampleRate for AudioContext due to FF not supporting this. #22

New issue

Closed

opened 2026-10-15 13:27:28 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-15 13:27:28 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/SillyTavern/Extension-Speech-Recognition/pull/15
Author: @yar3333
Created: 11/9/2024
Status: ❌ Closed

Base: main ← Head: main

📝 Commits (2)

0c6d1ca Remove sampleRate for AudioContext due to FF not supporting this.
aab4cf8 minor

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 index.js (+1 -1)

📄 Description

I made test with kobolcpp (fresh Chrome and Firefox).

Before my fix:

Chrome: always output "you" or "."
Firefox: exception on audioContext.createMediaStreamSource(stream)

After my fix:

Chrome: always output "you" or "."
Firefox: work good

I couldn't explain these results :)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/SillyTavern/Extension-Speech-Recognition/pull/15 **Author:** [@yar3333](https://github.com/yar3333) **Created:** 11/9/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (2) - [`0c6d1ca`](https://github.com/SillyTavern/Extension-Speech-Recognition/commit/0c6d1cae413020f9437622a5a10905201d79cf91) Remove sampleRate for AudioContext due to FF not supporting this. - [`aab4cf8`](https://github.com/SillyTavern/Extension-Speech-Recognition/commit/aab4cf8dc4aecb9fb8955ac4b40a19725671e7a9) minor ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `index.js` (+1 -1) </details> ### 📄 Description I made test with kobolcpp (fresh Chrome and Firefox). Before my fix: - Chrome: always output "you" or "." - Firefox: exception on `audioContext.createMediaStreamSource(stream)` After my fix: - Chrome: always output "you" or "." - Firefox: work good I couldn't explain these results :) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-15 13:27:28 +00:00