[PR #67] [MERGED] Fix: inverted sense bug with cuda sd float32 #174

New issue

Closed

opened 2026-10-15 18:05:18 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-15 18:05:18 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/SillyTavern/SillyTavern-Extras/pull/67
Author: @majick
Created: 6/28/2023
Status: ✅ Merged
Merged: 6/28/2023
Merged by: @Cohee1207

Base: main ← Head: apple-silicon

📝 Commits (1)

dea4254 Fix: inverted sense bug with cuda sd float32

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 server.py (+2 -2)

📄 Description

Inverting the use of float16 with SD on cuda was introduced with my MPS hack. Total thinko on my part. Fixed.
Also, made the MPS changes more consistent with cuda_device, since we don't need a hardcoded value any more.

Sorry about the extra PR. 😓

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/SillyTavern/SillyTavern-Extras/pull/67 **Author:** [@majick](https://github.com/majick) **Created:** 6/28/2023 **Status:** ✅ Merged **Merged:** 6/28/2023 **Merged by:** [@Cohee1207](https://github.com/Cohee1207) **Base:** `main` ← **Head:** `apple-silicon` --- ### 📝 Commits (1) - [`dea4254`](https://github.com/SillyTavern/SillyTavern-Extras/commit/dea4254e011f11661c3fdb968951cfd0da5cfe80) Fix: inverted sense bug with cuda sd float32 ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `server.py` (+2 -2) </details> ### 📄 Description Inverting the use of float16 with SD on cuda was introduced with my MPS hack. Total thinko on my part. Fixed. Also, made the MPS changes more consistent with cuda_device, since we don't need a hardcoded value any more. Sorry about the extra PR. 😓 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-15 18:05:18 +00:00