mirror of
https://github.com/SillyTavern/SillyTavern-Extras.git
synced 2026-10-15 18:11:52 +00:00
[PR #209] [MERGED] talkinghead new features #232
Labels
No labels
bug
duplicate
planned
pull-request
under consideration
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
SillyTavern/SillyTavern-Extras#232
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/SillyTavern/SillyTavern-Extras/pull/209
Author: @Technologicat
Created: 12/22/2023
Status: ✅ Merged
Merged: 12/24/2023
Merged by: @Cohee1207
Base:
main← Head:talkinghead-next-pr📝 Commits (3)
ebbdc6ctalkinghead-next new featuresb1489aemerge TODO lists into the one inapp.py, remove done TODO item.ba28f6eupdate docstring📊 Changes
3 files changed (+373 additions, -190 deletions)
View changed files
📝
talkinghead/tha3/app/app.py(+367 -180)📝
talkinghead/tha3/app/manual_poser.py(+3 -7)📝
talkinghead/tha3/app/util.py(+3 -3)📄 Description
Here's the first batch of new features for
talkinghead:Also, some more code cleanup.
On an RTX 3070 Ti mobile, available render performance (with
separable_half) is now ~50 FPS at factory clock rate (1700 MHz), and ~40 FPS when underclocked to 1100 MHz. Actual network send performance, after the rate-limiting to at most 25 FPS, is around 21 FPS.Remaining TODOs are marked into
talkinghead/tha3/app/app.py, there's a TODO list at the beginning.I'll have to look at improving the network send next (I'd like it to produce a smooth 25 FPS, since there is definitely enough render performance for that), but I thought I'd post the new features now.
There are also some client-side bugs and missing features I might look into.
@Cohee1207: Comments?
EDIT: The plugin is now ~600 lines, up from the ~400 of the previous PR, due to the improved animations and the framerate limiter. I squash-merged all my
talkinghead-nextcommits into this PR and rebased it onto the latestupstream/main, so it's clean as well as easy to merge. All important changes are summarized above. The extra two commits below fix minor omissions. From there on, anything new will go into a new branch to avoid messing this one up. :)🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.