[PR #214] [MERGED] Talkinghead next3 #235

New issue

Closed

opened 2026-10-15 18:05:48 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-15 18:05:48 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/SillyTavern/SillyTavern-Extras/pull/214
Author: @Technologicat
Created: 1/9/2024
Status: ✅ Merged
Merged: 1/9/2024
Merged by: @Cohee1207

Base: main ← Head: talkinghead-next3

📝 Commits (10+)

52d2825 remove done TODO item
387553d remove outdated comment
4bd66fa update TODO
c215cef improve comments
5ea734b improve talking animation
fc58895 update TODO list
e945212 API cleanliness
6633535 autopep8, and also apply some idiomatic Python style manually.
0228bdd add troubleshooting
fb9051c update TODO

📊 Changes

35 files changed (+559 additions, -258 deletions)

View changed files

📝 server.py (+78 -84)
📝 talkinghead/README.md (+19 -0)
📝 talkinghead/TODO.md (+23 -35)
📝 talkinghead/emotions/_defaults.json (+13 -8)
📝 talkinghead/emotions/admiration.json (+3 -2)
📝 talkinghead/emotions/amusement.json (+3 -2)
📝 talkinghead/emotions/anger.json (+3 -2)
📝 talkinghead/emotions/annoyance.json (+3 -2)
📝 talkinghead/emotions/approval.json (+3 -2)
📝 talkinghead/emotions/caring.json (+3 -2)
📝 talkinghead/emotions/confusion.json (+3 -2)
📝 talkinghead/emotions/curiosity.json (+3 -2)
📝 talkinghead/emotions/desire.json (+3 -2)
📝 talkinghead/emotions/disappointment.json (+3 -2)
📝 talkinghead/emotions/disapproval.json (+3 -2)
📝 talkinghead/emotions/disgust.json (+3 -2)
📝 talkinghead/emotions/embarrassment.json (+3 -2)
📝 talkinghead/emotions/excitement.json (+3 -2)
📝 talkinghead/emotions/fear.json (+3 -2)
📝 talkinghead/emotions/gratitude.json (+3 -2)

...and 15 more files

📄 Description

Improve talking animation, looks at least serviceable for now.
- There's still a small delay at the client end, after the AI starts writing and before the animation starts, but I haven't yet figured out the cause.
Decouple animation speed (w.r.t. walltime) from render FPS.
- Now if rendering is slow, the animator effectively skips frames (like most video games do) instead of slowing down to a crawl.
- Only the pose interpolator needed a nonlinear scaling applied to its step size; all other animation drivers (blinking, talking, breathing) were already defined in terms of wall time.
Code cleanup.
- Refactor model installer.
- Division of responsibilities: set_emotion, set_emotion_from_classification.
- Use consistent API endpoint naming scheme for the server functions implementing the endpoints.
- Add some docstrings.
- autopep8 server.py, and also manually make the code into more idiomatic Python (no more flake8 warnings).
  - This is isolated to commit 6633535, just in case if it's not desirable.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/SillyTavern/SillyTavern-Extras/pull/214 **Author:** [@Technologicat](https://github.com/Technologicat) **Created:** 1/9/2024 **Status:** ✅ Merged **Merged:** 1/9/2024 **Merged by:** [@Cohee1207](https://github.com/Cohee1207) **Base:** `main` ← **Head:** `talkinghead-next3` --- ### 📝 Commits (10+) - [`52d2825`](https://github.com/SillyTavern/SillyTavern-Extras/commit/52d2825e4f5f8da25d1a01bf6f787732d0bed879) remove done TODO item - [`387553d`](https://github.com/SillyTavern/SillyTavern-Extras/commit/387553d2c4fad88e10f9e0ca3aed277db12426d5) remove outdated comment - [`4bd66fa`](https://github.com/SillyTavern/SillyTavern-Extras/commit/4bd66faeea8bcb1f738a0fcd14ae0fa75fbeaf2d) update TODO - [`c215cef`](https://github.com/SillyTavern/SillyTavern-Extras/commit/c215cef908376ac5eb6e0be0b2420d9b6138a651) improve comments - [`5ea734b`](https://github.com/SillyTavern/SillyTavern-Extras/commit/5ea734b5a587010e0f89e7a0e6149798075578f7) improve talking animation - [`fc58895`](https://github.com/SillyTavern/SillyTavern-Extras/commit/fc58895a629a415e53c35940db592bcda2b436d3) update TODO list - [`e945212`](https://github.com/SillyTavern/SillyTavern-Extras/commit/e94521251fa9fb303a60f0391d56f5edb41a710a) API cleanliness - [`6633535`](https://github.com/SillyTavern/SillyTavern-Extras/commit/6633535e19c849df3f5ad8568472d7824396bd4c) autopep8, and also apply some idiomatic Python style manually. - [`0228bdd`](https://github.com/SillyTavern/SillyTavern-Extras/commit/0228bddc1b8f217a14e27a4a8b33d6a8d6ffcf3d) add troubleshooting - [`fb9051c`](https://github.com/SillyTavern/SillyTavern-Extras/commit/fb9051cd70f061fdfba6164aa9e5b3d5dc265840) update TODO ### 📊 Changes **35 files changed** (+559 additions, -258 deletions) <details> <summary>View changed files</summary> 📝 `server.py` (+78 -84) 📝 `talkinghead/README.md` (+19 -0) 📝 `talkinghead/TODO.md` (+23 -35) 📝 `talkinghead/emotions/_defaults.json` (+13 -8) 📝 `talkinghead/emotions/admiration.json` (+3 -2) 📝 `talkinghead/emotions/amusement.json` (+3 -2) 📝 `talkinghead/emotions/anger.json` (+3 -2) 📝 `talkinghead/emotions/annoyance.json` (+3 -2) 📝 `talkinghead/emotions/approval.json` (+3 -2) 📝 `talkinghead/emotions/caring.json` (+3 -2) 📝 `talkinghead/emotions/confusion.json` (+3 -2) 📝 `talkinghead/emotions/curiosity.json` (+3 -2) 📝 `talkinghead/emotions/desire.json` (+3 -2) 📝 `talkinghead/emotions/disappointment.json` (+3 -2) 📝 `talkinghead/emotions/disapproval.json` (+3 -2) 📝 `talkinghead/emotions/disgust.json` (+3 -2) 📝 `talkinghead/emotions/embarrassment.json` (+3 -2) 📝 `talkinghead/emotions/excitement.json` (+3 -2) 📝 `talkinghead/emotions/fear.json` (+3 -2) 📝 `talkinghead/emotions/gratitude.json` (+3 -2) _...and 15 more files_ </details> ### 📄 Description - Improve talking animation, looks at least serviceable for now. - There's still a small delay at the client end, after the AI starts writing and before the animation starts, but I haven't yet figured out the cause. - Decouple animation speed (w.r.t. walltime) from render FPS. - Now if rendering is slow, the animator effectively skips frames (like most video games do) instead of slowing down to a crawl. - Only the pose interpolator needed a nonlinear scaling applied to its step size; all other animation drivers (blinking, talking, breathing) were already defined in terms of wall time. - Code cleanup. - Refactor model installer. - Division of responsibilities: `set_emotion`, `set_emotion_from_classification`. - Use consistent API endpoint naming scheme for the server functions implementing the endpoints. - Add some docstrings. - autopep8 `server.py`, and also manually make the code into more idiomatic Python (no more `flake8` warnings). - This is isolated to commit 6633535, just in case if it's not desirable. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-15 18:05:48 +00:00