mirror of
https://github.com/SillyTavern/SillyTavern-GreetingTools.git
synced 2026-10-15 18:11:49 +00:00
[PR #2] Fix: Greeting macros #3
Labels
No labels
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
SillyTavern/SillyTavern-GreetingTools#3
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/SillyTavern/SillyTavern-GreetingTools/pull/2
Author: @Vagrancy5109
Created: 5/19/2026
Status: 🔄 Open
Base:
main← Head:FixGreetingMacros📝 Commits (5)
46cef85Macro insertion fixes4084279Updated substituteParams to reflect SillyTavernf5b1008Fixed {{if}} macro handling for existing titlesbe5e296Added preprocessor for if blocks6e576a8Attempt to fix temporary greetings📊 Changes
2 files changed (+47 additions, -5 deletions)
View changed files
📝
src/generator.js(+37 -5)📝
src/popup.js(+10 -0)📄 Description
The {{customPrompt}} and {{existingTitles}} Macros were broken and didn't work anymore. This fixes it. It also now works with ST v1.18 vanilla (not tested for minimum version, but should work with down to v1.15 too, since the macro engine was introduced then.) Also checks for temporary greetings, and includes them in the greeting titles section.
I'm not sure how to change the release tag in the readme file as this is my first time doing a PR for a SillyTavern extension, if someone could test it and take a look.
@Wolfsblvt
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.