mirror of
https://github.com/SillyTavern/SillyTavern-Launcher.git
synced 2026-11-05 00:27:39 +00:00
[PR #45] POC for Winget Depends Launcher needs winget removed too #102
Labels
No labels
🚏 Awaiting User Response
🐛Bug
🐛Bug
🐛Bug
🦄 Feature Request
✅ Fixed
✅ Fixed
👩💻 Good First Issue
‼️ High Priority
🧑💻 In Progress
🐧 Linux
🐧 Linux
💤 Low Priority
🍎 Mac
❕ Medium Priority
pull-request
🪟 Windows
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
SillyTavern/SillyTavern-Launcher#102
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/SillyTavern/SillyTavern-Launcher/pull/45
Author: @freeload101
Created: 4/7/2024
Status: 🔄 Open
Base:
main← Head:patch-1📝 Commits (1)
a247cacPOC for Winget Depends Launcher needs winget removed too📊 Changes
1 file changed (+17 additions, -60 deletions)
View changed files
📝
installer.bat(+17 -60)📄 Description
I can simplify the winget dependencies for you. After checking the Installer.bat and moving to Launcher.bat, I noticed it's installing about 10 other apps with winget... The colors are off and it installs get every time but you get the point.
Love the .bat colors it's a lot easier to do all that in powershell ... took me like 5+ years to stop using .bat so I know how it feels. I still use .bat to call powershell sometimes to bypass EDR ...
Other items need winget depends removed:
1833: winget install -e --id 7zip.7zip #
github.com/freeload101/Java-Android-Magisk-Burp-Objection-Root-Emulator-Easy@c4ea1a3b30/JAMBOREE.ps1 (L1531)Line 1940: winget install -e --id OpenJS.NodeJS # wait ..
Line 1948: winget install -e --id MikeFarah.yq # IDK ..
Line 2488: winget uninstall --id 7zip.7zip #
github.com/freeload101/Java-Android-Magisk-Burp-Objection-Root-Emulator-Easy@c4ea1a3b30/JAMBOREE.ps1 (L1531)Line 2504: winget uninstall --id OpenJS.NodeJS # wait again ? I think the dupe code can be conbined by using call and exit codes Referernce
github.com/freeload101/Bloodhound-Portable@fb3db2dad0/BloodHound_Portable.bat (L53)Line 2513: winget uninstall --id MikeFarah.yq # no idea on this one
Line 2522: winget uninstall --id Nvidia.CUDA ## IDK how to know what ver of cuda to install ?!
Line 2530: winget uninstall --id Microsoft.VisualStudio.2022.BuildTools # fixed in installer.bat
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.