[PR #45] POC for Winget Depends Launcher needs winget removed too #102

Open
opened 2026-10-15 18:07:00 +00:00 by bsakaguchi · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/SillyTavern/SillyTavern-Launcher/pull/45
Author: @freeload101
Created: 4/7/2024
Status: 🔄 Open

Base: main ← Head: patch-1


📝 Commits (1)

  • a247cac POC for Winget Depends Launcher needs winget removed too

📊 Changes

1 file changed (+17 additions, -60 deletions)

View changed files

📝 installer.bat (+17 -60)

📄 Description

I can simplify the winget dependencies for you. After checking the Installer.bat and moving to Launcher.bat, I noticed it's installing about 10 other apps with winget... The colors are off and it installs get every time but you get the point.

Love the .bat colors it's a lot easier to do all that in powershell ... took me like 5+ years to stop using .bat so I know how it feels. I still use .bat to call powershell sometimes to bypass EDR ...

Other items need winget depends removed:

1833: winget install -e --id 7zip.7zip # github.com/freeload101/Java-Android-Magisk-Burp-Objection-Root-Emulator-Easy@c4ea1a3b30/JAMBOREE.ps1 (L1531)
Line 1940: winget install -e --id OpenJS.NodeJS # wait ..
Line 1948: winget install -e --id MikeFarah.yq # IDK ..
Line 2488: winget uninstall --id 7zip.7zip # github.com/freeload101/Java-Android-Magisk-Burp-Objection-Root-Emulator-Easy@c4ea1a3b30/JAMBOREE.ps1 (L1531)
Line 2504: winget uninstall --id OpenJS.NodeJS # wait again ? I think the dupe code can be conbined by using call and exit codes Referernce github.com/freeload101/Bloodhound-Portable@fb3db2dad0/BloodHound_Portable.bat (L53)
Line 2513: winget uninstall --id MikeFarah.yq # no idea on this one
Line 2522: winget uninstall --id Nvidia.CUDA ## IDK how to know what ver of cuda to install ?!
Line 2530: winget uninstall --id Microsoft.VisualStudio.2022.BuildTools # fixed in installer.bat


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/SillyTavern/SillyTavern-Launcher/pull/45 **Author:** [@freeload101](https://github.com/freeload101) **Created:** 4/7/2024 **Status:** 🔄 Open **Base:** `main` ← **Head:** `patch-1` --- ### 📝 Commits (1) - [`a247cac`](https://github.com/SillyTavern/SillyTavern-Launcher/commit/a247cac1d178509f54e0f4d640793a75852b3903) POC for Winget Depends Launcher needs winget removed too ### 📊 Changes **1 file changed** (+17 additions, -60 deletions) <details> <summary>View changed files</summary> 📝 `installer.bat` (+17 -60) </details> ### 📄 Description I can simplify the winget dependencies for you. After checking the Installer.bat and moving to Launcher.bat, I noticed it's installing about 10 other apps with winget... The colors are off and it installs get every time but you get the point. Love the .bat colors it's a lot easier to do all that in powershell ... took me like 5+ years to stop using .bat so I know how it feels. I still use .bat to call powershell sometimes to bypass EDR ... Other items need winget depends removed: 1833: winget install -e --id 7zip.7zip # https://github.com/freeload101/Java-Android-Magisk-Burp-Objection-Root-Emulator-Easy/blob/c4ea1a3b309a41e43386eb2b8ee18459118f8465/JAMBOREE.ps1#L1531 Line 1940: winget install -e --id OpenJS.NodeJS # [wait .. ](https://github.com/freeload101/Java-Android-Magisk-Burp-Objection-Root-Emulator-Easy/blob/c4ea1a3b309a41e43386eb2b8ee18459118f8465/JAMBOREE.ps1#L316) Line 1948: winget install -e --id MikeFarah.yq # IDK .. Line 2488: winget uninstall --id 7zip.7zip # https://github.com/freeload101/Java-Android-Magisk-Burp-Objection-Root-Emulator-Easy/blob/c4ea1a3b309a41e43386eb2b8ee18459118f8465/JAMBOREE.ps1#L1531 Line 2504: winget uninstall --id OpenJS.NodeJS # wait again ? I think the dupe code can be conbined by using call and exit codes Referernce https://github.com/freeload101/Bloodhound-Portable/blob/fb3db2dad0b182a86683acf56310d29a41ba7e62/BloodHound_Portable.bat#L53 Line 2513: winget uninstall --id MikeFarah.yq # no idea on this one Line 2522: winget uninstall --id Nvidia.CUDA ## IDK how to know what ver of cuda to install ?! Line 2530: winget uninstall --id Microsoft.VisualStudio.2022.BuildTools # fixed in installer.bat --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Sign in to join this conversation.
No description provided.