mirror of
https://github.com/SillyTavern/SillyTavern-Launcher.git
synced 2026-11-05 00:27:39 +00:00
Labels
No labels
🚏 Awaiting User Response
🐛Bug
🐛Bug
🐛Bug
🦄 Feature Request
✅ Fixed
✅ Fixed
👩💻 Good First Issue
‼️ High Priority
🧑💻 In Progress
🐧 Linux
🐧 Linux
💤 Low Priority
🍎 Mac
❕ Medium Priority
pull-request
🪟 Windows
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
SillyTavern/SillyTavern-Launcher#115
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/SillyTavern/SillyTavern-Launcher/pull/76
Author: @JaceEthaniel
Created: 9/25/2024
Status: ❌ Closed
Base:
main← Head:main📝 Commits (2)
7fd6a20Update Launcher.batb70b5baUpdate gpu_info.bat📊 Changes
2 files changed (+58 additions, -22 deletions)
View changed files
📝
Launcher.bat(+24 -2)📝
bin/functions/Toolbox/Troubleshooting/gpu_info.bat(+34 -20)📄 Description
This adds iteration in two places it greatly needs it. The launcher.bat file and the gpu_info.bat file.
Issue: The bat files in question always pick the first GPU available, instead of iterating through the available GPUs and picking the one with the most VRAM. These updates allow the files to do so...
However, I don't normally write in Batch script, so the edits are... not that well thought out. Currently, it will pick the last GPU available, unless the second to last GPU has more VRAM.
Simply put... I didn't have the time to figure out how to create a list of the available GPUs and compare them to find the one with the greatest VRAM. Considering I only had an hour to spare when I found where the issue was and spent most of that time looking up how to write in Batch... I hope you can improve upon this. It is at least GoodEnough(tm) for most cases... on Windows.
I should also note that I did not make any changes to the launcher.sh script... because that is a whole other can of worms.
Good night!
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.