mirror of
https://github.com/SillyTavern/SillyTavern-Launcher.git
synced 2026-11-05 00:27:39 +00:00
[PR #78] [MERGED] [BUG] Dual GPU displaying incorrect VRAM (and preventing models from being downloaded via launcher) #117
Labels
No labels
🚏 Awaiting User Response
🐛Bug
🐛Bug
🐛Bug
🦄 Feature Request
✅ Fixed
✅ Fixed
👩💻 Good First Issue
‼️ High Priority
🧑💻 In Progress
🐧 Linux
🐧 Linux
💤 Low Priority
🍎 Mac
❕ Medium Priority
pull-request
🪟 Windows
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
SillyTavern/SillyTavern-Launcher#117
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/SillyTavern/SillyTavern-Launcher/pull/78
Author: @JaceEthaniel
Created: 9/25/2024
Status: ✅ Merged
Merged: 9/28/2024
Merged by: @deffcolony
Base:
main← Head:main📝 Commits (2)
39aec81Update gpu_info.bat964d060Update Launcher.bat📊 Changes
2 files changed (+58 additions, -22 deletions)
View changed files
📝
Launcher.bat(+24 -2)📝
bin/functions/Toolbox/Troubleshooting/gpu_info.bat(+34 -20)📄 Description
This adds changes to Launcher.bat and gpu_info.bat to allow them to iterate through the GPUs on a system and pick the one with the most VRAM... from among the last two GPUs on the system. If you have more than two GPUs... say three... and the first one is one with the most VRAM, you will be out of luck. Because this picks from among the last two.
What should be changed... is that it needs to be made into a list and have the list compared to see which is the better performer, then select based on that result. I will probably figure out how to do that in a couple days.
(New pull request because I am silly and don't know how git hub works, so I'm worried my proposed changes would overwrite the recent update... so I made a new fork with the updates and now this pull request...) I think I did it right?
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.