mirror of
https://github.com/SillyTavern/SillyTavern-Launcher.git
synced 2026-11-05 00:27:39 +00:00
[PR #81] [CLOSED] Update Launcher.bat GPU detection code, and others. #119
Labels
No labels
🚏 Awaiting User Response
🐛Bug
🐛Bug
🐛Bug
🦄 Feature Request
✅ Fixed
✅ Fixed
👩💻 Good First Issue
‼️ High Priority
🧑💻 In Progress
🐧 Linux
🐧 Linux
💤 Low Priority
🍎 Mac
❕ Medium Priority
pull-request
🪟 Windows
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
SillyTavern/SillyTavern-Launcher#119
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/SillyTavern/SillyTavern-Launcher/pull/81
Author: @JaceEthaniel
Created: 9/30/2024
Status: ❌ Closed
Base:
main← Head:main📝 Commits (6)
34ddcc1Update Launcher.bat0b71f9dReplace gpu_info.bat with gpu_info.ps1b9259daUpdate gpu_info.ps13403267Removed redundant comment...d047038Removed unneeded cd call.3687965Just a slight alteration to a comment...📊 Changes
3 files changed (+52 additions, -84 deletions)
View changed files
📝
Launcher.bat(+18 -37)➖
bin/functions/Toolbox/Troubleshooting/gpu_info.bat(+0 -47)➕
bin/functions/Toolbox/Troubleshooting/gpu_info.ps1(+34 -0)📄 Description
As promised... I learned more about batch and have now updated the code for GPU detection in the launcher.bat file, and replaced gpu_info.bat with gpu_info.ps1 because batch is not good at handling/ sorting gpu information. As a result, it is more streamlined and will now pick the GPU with the most VRAM from among all installed gpus, instead of only the last two.
I know. I know. I learned more about batch and so I replaced the batch code with powershell code... but I also made other edits:
I have altered how the GPU information is stored, displayed on the home screen, and how frequently the gpu_info script is called. First, GPU info for the preferred GPU is now stored to the log file without ANSI codes by using the variables set previously (instead of making another call to gpu_info.ps1). Second, the gpuInfo variable is also set using the two variables previously set and is formatted at the same time to include ANSI codes (that way we don't have ANSI codes in places we don't want them). As a result, the gpu_info.ps1 script is only called once at startup and never again; but that is fine since it will always run before the menu is displayed.
I only have one computer, however, so I have not tested it with anything other than a computer with two GPUs. If you have one GPU, or more than two GPUs, you will need to test it.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.