[PR #94] [MERGED] Return to parent directory after launching/before returning home #120

Closed
opened 2026-10-15 18:07:09 +00:00 by bsakaguchi · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/SillyTavern/SillyTavern-Launcher/pull/94
Author: @someotherotherguy
Created: 1/31/2025
Status: ✅ Merged
Merged: 1/31/2025
Merged by: @deffcolony

Base: main ← Head: patch-1


📝 Commits (2)

  • e52ce30 Go to parent directory after starting SillyTavern
  • bda8539 Rearrange cd's to make directory change more readable

📊 Changes

1 file changed (+3 additions, -2 deletions)

View changed files

📝 launcher.sh (+3 -2)

📄 Description

Noticed that after changing into and launching SillyTavern, the launcher script doesn't change back to the parent directory. Thus, when the user tries to launch again (assuming they terminated SillyTavern), it tries to change in into the SillyTavern from the SillyTavern directory and exits with something like ./launcher.sh: line 243: cd: SillyTavern: No such file or directory

I just threw in a cd .. like I saw in other functions - optionally, in my second commit, we might rearrange the cd "SillyTavern"'s to make it clearer that the if blocks take place in the SillyTavern directory.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/SillyTavern/SillyTavern-Launcher/pull/94 **Author:** [@someotherotherguy](https://github.com/someotherotherguy) **Created:** 1/31/2025 **Status:** ✅ Merged **Merged:** 1/31/2025 **Merged by:** [@deffcolony](https://github.com/deffcolony) **Base:** `main` ← **Head:** `patch-1` --- ### 📝 Commits (2) - [`e52ce30`](https://github.com/SillyTavern/SillyTavern-Launcher/commit/e52ce30c80f8da9284bec9b269e9810e863889c6) Go to parent directory after starting SillyTavern - [`bda8539`](https://github.com/SillyTavern/SillyTavern-Launcher/commit/bda8539fa9444186f5bce8b6dee94030558c2015) Rearrange cd's to make directory change more readable ### 📊 Changes **1 file changed** (+3 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `launcher.sh` (+3 -2) </details> ### 📄 Description Noticed that after changing into and launching SillyTavern, the launcher script doesn't change back to the parent directory. Thus, when the user tries to launch again (assuming they terminated SillyTavern), it tries to change in into the SillyTavern from the SillyTavern directory and exits with something like `./launcher.sh: line 243: cd: SillyTavern: No such file or directory` I just threw in a `cd ..` like I saw in other functions - optionally, in my second commit, we might rearrange the `cd "SillyTavern"`'s to make it clearer that the if blocks take place *in* the SillyTavern directory. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
bsakaguchi 2026-10-15 18:07:09 +00:00
Sign in to join this conversation.
No description provided.