[GH-ISSUE #40] [BUG] install.sh is looping #15

Closed
opened 2026-10-15 18:06:11 +00:00 by bsakaguchi · 2 comments
Owner

Originally created by @Tuerpe on GitHub (Mar 19, 2024).
Original GitHub issue: https://github.com/SillyTavern/SillyTavern-Launcher/issues/40

Environment

Linux

System

Arch-Linux

Describe the problem

The install.sh is looping. I looked up the script and here:

install_st_extras_post() {
    # Activate the extras environment
    log_message "INFO" "Activating Conda environment extras..."
    conda activate extras

    # Navigate to the SillyTavern-extras directory
    cd "$PWD/SillyTavern-extras"

    # Use the GPU choice made earlier to install requirements for extras
    if [ "$GPU_CHOICE" == "1" ]; then
        log_message "INFO" "Installing modules for NVIDIA from requirements.txt in extras"
        pip3 install -r requirements.txt
        conda install -c conda-forge faiss-gpu -y
        install_st_extras_post
    elif [ "$GPU_CHOICE" == "2" ]; then
        log_message "INFO" "Installing modules for AMD from requirements-rocm.txt in extras"
        pip3 install -r requirements-rocm.txt
        install_st_extras_post
    elif [ "$GPU_CHOICE" == "3" ]; then
        log_message "INFO" "Installing modules for CPU from requirements-silicon.txt in extras"
        pip3 install -r requirements-silicon.txt
        install_st_extras_post
    fi

... it just keeps itself invoking. It doenst get any further. Is this the issue or is it something else why my installation is looping here?

Additional info

No response

Please tick the boxes

Originally created by @Tuerpe on GitHub (Mar 19, 2024). Original GitHub issue: https://github.com/SillyTavern/SillyTavern-Launcher/issues/40 ### Environment Linux ### System Arch-Linux ### Describe the problem The install.sh is looping. I looked up the script and here: ``` install_st_extras_post() { # Activate the extras environment log_message "INFO" "Activating Conda environment extras..." conda activate extras # Navigate to the SillyTavern-extras directory cd "$PWD/SillyTavern-extras" # Use the GPU choice made earlier to install requirements for extras if [ "$GPU_CHOICE" == "1" ]; then log_message "INFO" "Installing modules for NVIDIA from requirements.txt in extras" pip3 install -r requirements.txt conda install -c conda-forge faiss-gpu -y install_st_extras_post elif [ "$GPU_CHOICE" == "2" ]; then log_message "INFO" "Installing modules for AMD from requirements-rocm.txt in extras" pip3 install -r requirements-rocm.txt install_st_extras_post elif [ "$GPU_CHOICE" == "3" ]; then log_message "INFO" "Installing modules for CPU from requirements-silicon.txt in extras" pip3 install -r requirements-silicon.txt install_st_extras_post fi ``` ... it just keeps itself invoking. It doenst get any further. Is this the issue or is it something else why my installation is looping here? ### Additional info _No response_ ### Please tick the boxes - [X] You have explained the issue clearly, and included all relevant info - [X] You've checked that this [issue hasn't already been raised](https://github.com/SillyTavern/SillyTavern-Launcher/issues?q=is%3Aissue) - [X] You've checked the [docs](https://docs.sillytavern.app/) ![important](https://img.shields.io/badge/Important!-F6094E)
Author
Owner

@deffcolony commented on GitHub (Mar 22, 2024):

@Tuerpe could you test if it works now? i made some big changes to the install.sh
github.com/SillyTavern/SillyTavern-Launcher@afe33f485c (diff-043df5bdbf)

<!-- gh-comment-id:2014998032 --> @deffcolony commented on GitHub (Mar 22, 2024): @Tuerpe could you test if it works now? i made some big changes to the `install.sh` https://github.com/SillyTavern/SillyTavern-Launcher/commit/afe33f485cdaad7028bbc98d5552c7eef229cada#diff-043df5bdbf6639d7a77e1d44c5226fd7371e5259a1e4df3a0dd5d64c30dca44f
Author
Owner

@deffcolony commented on GitHub (Feb 24, 2025):

launcher got a massive update which fixed most bugs so should now be fixed at github.com/SillyTavern/SillyTavern-Launcher@240badb9c9 (diff-070e0054c9)

please update the launcher and let me know if everything works stable. i will close the issue now

<!-- gh-comment-id:2678341666 --> @deffcolony commented on GitHub (Feb 24, 2025): launcher got a massive update which fixed most bugs so should now be fixed at https://github.com/SillyTavern/SillyTavern-Launcher/commit/240badb9c9083ba1606dc51a10aadd438ea6fd73#diff-070e0054c9dc9d591e46936a2a58e2d098882038c888c1122fa439c3800532b9 please update the launcher and let me know if everything works stable. i will close the issue now
Sign in to join this conversation.
No description provided.