mirror of
https://github.com/SillyTavern/SillyTavern-Launcher.git
synced 2026-11-05 00:27:39 +00:00
[GH-ISSUE #23] -extras installer: conda, python, pip, OpenSUSE package installer #3
Labels
No labels
🚏 Awaiting User Response
🐛Bug
🐛Bug
🐛Bug
🦄 Feature Request
✅ Fixed
✅ Fixed
👩💻 Good First Issue
‼️ High Priority
🧑💻 In Progress
🐧 Linux
🐧 Linux
💤 Low Priority
🍎 Mac
❕ Medium Priority
pull-request
🪟 Windows
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
SillyTavern/SillyTavern-Launcher#3
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @ParaplegicRacehorse on GitHub (Dec 12, 2023).
Original GitHub issue: https://github.com/SillyTavern/SillyTavern-Launcher/issues/23
Originally assigned to: @deffcolony on GitHub.
The installer does not check for version conflicts when attempting to install miniconda.
At time of writing, the current release of miniconda requires Python v3.11.5. The miniconda website has installers for python3 versions older than v3.11.5. On Ubuntu LTS 22.04, for example, the latest python3 package is v3.10.12. A python3.11 package (binary called with
python3.11) is v3.11.0rc1. Lots of other distros in the wild also don't have near-bleeding-edge Python in their repositories.Unless you're planning to automate the process of version checking and installing the matching miniconda, the script should fail gracefully with a nice friendly notice that it doesn't know how to install miniconda on user's system and would user please go read the -extras README for instructions on how to manually install, with particular attention to visiting the miniconda website to learn about system requirements and download a miniconda installer that will work with user's system.
Also, pip should probably be called as
pip3to avoid calling the python2 pip where python2 may still exist alongside python3. Dunno about other distros, but pip3 exists on Debian/Ubuntu, Fedora, OpenSUSE, Arch.Also, OpenSUSE packager
zypperis not supported at all.zypper install [packagename]orzypper in [packagename]@ParaplegicRacehorse commented on GitHub (Dec 12, 2023):
Hmm. Actually, it might be interesting to check if Docker or Podman are installed and do a --build (or pull a prebuilt registry image) instead of screwing around with python and miniconda.
@deffcolony commented on GitHub (Dec 31, 2023):
@ParaplegicRacehorse i changed pip to pip3 and added support for OpenSUSE packager zypper. so you can already update now but i still need to look at the version conflicts part