mirror of
https://github.com/SillyTavern/SillyTavern-Launcher.git
synced 2026-11-05 00:27:39 +00:00
[GH-ISSUE #72] [BUG] Dual GPU displaying incorrect VRAM #32
Labels
No labels
🚏 Awaiting User Response
🐛Bug
🐛Bug
🐛Bug
🦄 Feature Request
✅ Fixed
✅ Fixed
👩💻 Good First Issue
‼️ High Priority
🧑💻 In Progress
🐧 Linux
🐧 Linux
💤 Low Priority
🍎 Mac
❕ Medium Priority
pull-request
🪟 Windows
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
SillyTavern/SillyTavern-Launcher#32
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @eeljpg on GitHub (Aug 24, 2024).
Original GitHub issue: https://github.com/SillyTavern/SillyTavern-Launcher/issues/72
Environment
🪟 Windows
System
Windows 11 23H2
Describe the problem
I have both an iGPU and a dedicated eGPU. The launcher displays my VRAM as the iGPU vram while still recognizing the eGPU. It says:
"GPU: NVIDIA GeForce RTX 3090 - VRAM: 4 GB".
Problem does not exist in automatic1111 sd or task manager.
For full disclosure, the GPU is an egpu through Oculink. Still works fine and all 24gb vram are usable. Not looking to use iGPU vram. LLMs still utilize 24gb of 3090 VRAM, so it seems to be a display error only.
Additional info
SillyTavern: 1.12.4
STL: 24.1.3.0
GPU: NVIDIA GeForce RTX 3090 - VRAM: 4 GB
Please tick the boxes
@BlueprintCoding commented on GitHub (Aug 28, 2024):
@eeljpg pushed a fix for this. Not 100% sure it will work as my desktop does not have integrated graphics but I'm pretty confident it will work. Let me know if works or not.
github.com/SillyTavern/SillyTavern-Launcher@c7825eeb76@eeljpg commented on GitHub (Aug 30, 2024):
Updated, still displaying GPU: NVIDIA GeForce RTX 3090 - VRAM: 4 GB
I noticed the change involved adding an Intel graphics check, my iGPU is AMD. It comes up in task manager as "AMD Radeon 780M Graphics"
@BlueprintCoding commented on GitHub (Aug 31, 2024):
@eeljpg Please let me know if the newest update works.
github.com/SillyTavern/SillyTavern-Launcher@8bb38755db@BlueprintCoding commented on GitHub (Sep 4, 2024):
Issue will be closed in a few days if no response.
@eeljpg commented on GitHub (Sep 10, 2024):
Hello, my bad. Issue is still present on latest.
Looking at the changes, it seems the check added was for Intel(R) HD Graphics, but I have an AMD iGPU.
@BlueprintCoding commented on GitHub (Sep 18, 2024):
Unfortunately the core of this issue relates to external GPUs and without an eGPU to be able to test on I'm not sure I will be able to create a fix for this. There is no way I can find to detect AMD iGPUs in the registry or wmic without finding a list of every AMD iGPU and hardcoding a check against each of them.
Since this is not an issue that will effect 99% of users and doesn't prevent the launcher from working, just doesn't show correct VRAM which is a "quality of life" feature. I will be closing this issue.
@JaceEthaniel commented on GitHub (Sep 25, 2024):
I also had this problem.
For reference, I have an AMD processor with a built in GPU, and I also have an NVIDIA RTX 4070TI Super...
The original script was only ever selecting the first iterated GPU, so this changes it so it will iterate through all the GPUs.
One of the errors was that the "AdapterRAM > 0" would always return true, because most iGPUs have more than 0 VRAM...
For example: my return of the wmic command shows me to have 536870912 AdapterRAM on my AMD Radeon(TM) Graphics entry; which is greater than 0, and so it was being chosen.
To fix that, I changed it to this and it works for me now (this could very much be done better, but I made these changes after searching on google for an hour on how to write in batch... so excuse the mess):
FILENAME: gpu_info.bat
With that being said, when I tried to then download a model for TabbyAPI, it said I didn't have enough VRAM, so there are more places that need to be fixed than just the gpu_info.bat file.
@JaceEthaniel commented on GitHub (Sep 25, 2024):
It is the launcher.bat that needs fixing too... It uses the same non-iterating powershell script to get the VRAM for the GPU, which only returns the first GPU (which is always an iGPU if it exists.)
So I replaced the part that normally finds the VRAM (at lines 431-433) with this and it works now:
@deffcolony commented on GitHub (Sep 25, 2024):
@JaceEthaniel If you believe this change improves the launcher for everyone, I recommend you to make a pull request. This way, your contribution can be properly reviewed and integrated, and your name will automatically be added to the contributor list. It's a better approach than posting the fixed code in a comment, it provides proper credit for your work.
@JaceEthaniel commented on GitHub (Oct 10, 2024):
@eeljpg does the problem still exist for you?
@eeljpg commented on GitHub (Oct 13, 2024):
So, funny news. My GPU died so I don't have an eGPU setup anymore and I built a whole new PC. Still have a different non-external 3090 though. As my hardware is entirely different now and there isn't an egpu, I wasn't expecting the issue to still exist, but it seems I carry a special level of edge-case energy as it now displays "GPU: Parsec Virtual Display Adapter - VRAM: 24 GB". Weirdly, it persists in showing this even if I disable the parsec adapter in device manager.
@JaceEthaniel commented on GitHub (Oct 13, 2024):
I see, so you still have the driver installed and it is being detected as an actual GPU... Unfortunately I am not well-versed enough to solve that particular problem with an auto-select method like what is currently in place. I would suggest trying to uninstall that driver if you don't expect to use it any time soon.
I have been quite busy with my classes, but I plan on eventually altering it so that you can choose the GPU you are using (and then, of course, making a pull request); that wont be for a while though...
Basically, my plan is to have it list all the GPUs you have on the first start up (it will check the GPU log file to see if it exists, and if not it will ask which GPU you will be using), then in the toolbox I am going to add an option to select a different GPU. Ultimately though it is primarily a visual thing. The only thing it actually affects is the launcher itself deciding if you have enough VRAM to run certain models. The actual image/text generators will use the correct GPU/driver (well, unless you are REALLY good at getting those edge-case issues).
@JaceEthaniel commented on GitHub (Dec 7, 2024):
Sometimes I am very smart, but sometimes I am not very smart.
@eeljpg, do me a favour... Go into your sillytavern-launcher install folder, find the bin folder, then the Logs folder, and delete the file "gpu_info_output.txt"
For me that would be... "C:\AI-Stuff\SillyTavern-Launcher\bin\logs\gpu_info_output.txt"
Once you do that, re-launch the Silly Tavern Launcher and let me know if it resolves the display issue.
Please and thank you.
@eeljpg commented on GitHub (Dec 7, 2024):
I've deleted it, it seems the GPU doesn't display in the launcher at all. The file is regenerated with the following text:
Additionally, the gpu_counter file seems to start at 1 and increase with every launch. On STL: 24.1.5.0
@deffcolony commented on GitHub (Dec 7, 2024):
@eeljpg okay so you open regedit go to the following string:
Computer\HKEY_LOCAL_MACHINE\SYSTEM\ControlSet001\Control\Class\{4d36e968-e325-11ce-bfc1-08002be10318}\then check one of the numbers and look for your gpu name like look for HardwareInformation.AdapterString you should see ur gpu name... if you replaced your gpu recently with a newer one then you delete the entire number folder that still has ur old gpu name
for example

@eeljpg commented on GitHub (Dec 9, 2024):
Folder 0000 is the 3090, the Parsec virtual display adapter displays in folder 0004 (with 0002 being integrated AMD and 0003 being a Meta virtual display) Not sure if deleting those other folders will cause issues with other programs, especially the virtual display ones.
