[PR #37] Update install.sh, deletes miniconda installer if interrupted #96

New issue

Open

opened 2026-10-15 18:06:58 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-15 18:06:58 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/SillyTavern/SillyTavern-Launcher/pull/37
Author: @pato-pan
Created: 2/27/2024
Status: 🔄 Open

Base: main ← Head: patch-2

📝 Commits (1)

e78888c Update install.sh

📊 Changes

1 file changed (+5 additions, -2 deletions)

View changed files

📝 install.sh (+5 -2)

📄 Description

Potential errors could be avoided and resources can be saved if the miniconda installer is deleted before downloading it again.

This is in the case the script is interrupted before the download is completed.

I thought that it would be better if it instead checked if it was already there, just so it doesn't have to download it again, but that would cause issues in case the existing file is incomplete or corrupted

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/SillyTavern/SillyTavern-Launcher/pull/37 **Author:** [@pato-pan](https://github.com/pato-pan) **Created:** 2/27/2024 **Status:** 🔄 Open **Base:** `main` ← **Head:** `patch-2` --- ### 📝 Commits (1) - [`e78888c`](https://github.com/SillyTavern/SillyTavern-Launcher/commit/e78888c73675614480939fbe7221fb90d03c63be) Update install.sh ### 📊 Changes **1 file changed** (+5 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `install.sh` (+5 -2) </details> ### 📄 Description Potential errors could be avoided and resources can be saved if the miniconda installer is deleted before downloading it again. This is in the case the script is interrupted before the download is completed. I thought that it would be better if it instead checked if it was already there, just so it doesn't have to download it again, but that would cause issues in case the existing file is incomplete or corrupted --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi added the

pull-request

label

2026-10-15 18:06:58 +00:00