SillyTavern/SillyTavern-Timelines
1
0
Fork 0
mirror of https://github.com/SillyTavern/SillyTavern-Timelines.git synced 2026-10-15 18:12:00 +00:00
Code Issues 9 Projects Packages Wiki Activity

[PR #20] [MERGED] fix bug: branching at a node with null swipe_id created broken chat #29

New issue
Closed
opened 2026-10-15 18:07:58 +00:00 by bsakaguchi · 0 comments
bsakaguchi commented 2026-10-15 18:07:58 +00:00
Owner
Copy link

📋 Pull Request Information

Original PR: https://github.com/SillyTavern/SillyTavern-Timelines/pull/20
Author: @Technologicat
Created: 2/6/2024
Status: ✅ Merged
Merged: 2/11/2024
Merged by: @Cohee1207

Base: master ← Head: fix-gotoswipe

📝 Commits (8)

  • 3ae0827 fix bug: branching at a node with null swipeId created broken chat
  • df59cac fix bug: cy is null when hitting Esc on "Manage chat files"
  • 5be0fe2 fix uncaught exception when the text search is empty
  • 7809b4a explicitly return undefined
  • b776650 once more, with consistency.
  • f2ff6b4 show loading spinner when opening Timelines
  • d9895bc fix root node ending up in stratosphere when lots of chats
  • 31bbf3a fix startup performance regression with loader spinner

📊 Changes

3 files changed (+80 additions, -8 deletions)

View changed files

📝 index.js (+67 -7)
📝 tl_graph.js (+1 -1)
📝 tl_utils.js (+12 -0)

📄 Description

As it says on the tin.

I don't know how I didn't catch this before - maybe it's only some chat files where a message has a null swipe_id.

Anyway, fixed, works now.

EDIT: Sneaked in another small bugfix.

Changelog:

  • Fix the branch button in the full info panel sometimes creating a broken chat
  • Fix exception in Timelines when hitting Esc to close the Manage chat files view (of core ST)
  • Fix and improve consistentency in handling of zoom to fit (no more uncaught exceptions from this, hopefully)
  • UX: Show loading spinner while the timeline view is opening
  • UX: Fix incorrect position of root node (especially if the character has lots of chats)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/SillyTavern/SillyTavern-Timelines/pull/20 **Author:** [@Technologicat](https://github.com/Technologicat) **Created:** 2/6/2024 **Status:** ✅ Merged **Merged:** 2/11/2024 **Merged by:** [@Cohee1207](https://github.com/Cohee1207) **Base:** `master` ← **Head:** `fix-gotoswipe` --- ### 📝 Commits (8) - [`3ae0827`](https://github.com/SillyTavern/SillyTavern-Timelines/commit/3ae0827a9eb1c9911b90837464da3419840506ee) fix bug: branching at a node with `null` swipeId created broken chat - [`df59cac`](https://github.com/SillyTavern/SillyTavern-Timelines/commit/df59cacfffda151824a74a076630003f4ef84418) fix bug: `cy is null` when hitting Esc on "Manage chat files" - [`5be0fe2`](https://github.com/SillyTavern/SillyTavern-Timelines/commit/5be0fe27972fbcf3f42ca00d4a4acff42e73cd0a) fix uncaught exception when the text search is empty - [`7809b4a`](https://github.com/SillyTavern/SillyTavern-Timelines/commit/7809b4a44db093f9d5de9de71ccda50e12a478a9) explicitly return undefined - [`b776650`](https://github.com/SillyTavern/SillyTavern-Timelines/commit/b776650ebcc23f26b62089607206fd181a00f04a) once more, with consistency. - [`f2ff6b4`](https://github.com/SillyTavern/SillyTavern-Timelines/commit/f2ff6b4883051c00b99fc7a5422f5509610a5ce3) show loading spinner when opening Timelines - [`d9895bc`](https://github.com/SillyTavern/SillyTavern-Timelines/commit/d9895bc0110c53a29788fc975b74aaf0d8e1eb81) fix root node ending up in stratosphere when lots of chats - [`31bbf3a`](https://github.com/SillyTavern/SillyTavern-Timelines/commit/31bbf3a29cdaf86eef92489ee17f344757fd67c6) fix startup performance regression with loader spinner ### 📊 Changes **3 files changed** (+80 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `index.js` (+67 -7) 📝 `tl_graph.js` (+1 -1) 📝 `tl_utils.js` (+12 -0) </details> ### 📄 Description As it says on the tin. I don't know how I didn't catch this before - maybe it's only some chat files where a message has a null `swipe_id`. Anyway, fixed, works now. **EDIT**: *Sneaked in another small bugfix.* **Changelog**: - Fix the branch button in the full info panel sometimes creating a broken chat - Fix exception in Timelines when hitting Esc to close the *Manage chat files* view (of core ST) - Fix and improve consistentency in handling of zoom to fit (no more uncaught exceptions from this, hopefully) - UX: Show loading spinner while the timeline view is opening - UX: Fix incorrect position of root node (especially if the character has lots of chats) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
bsakaguchi 2026-10-15 18:07:58 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
feature/swipes
dev
1.2
Labels
Clear labels   
pull-request
Mirrored from GitHub Pull Request

No labels
pull-request
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
SillyTavern/SillyTavern-Timelines#29
No description provided.