SillyTavern/SillyTavern-WebSearch-Selenium
1
0
Fork 0
mirror of https://github.com/SillyTavern/SillyTavern-WebSearch-Selenium.git synced 2026-11-05 00:37:40 +00:00
Code Issues 8 Projects Packages Wiki Activity

[PR #6] [MERGED] Increase number of links able to be collected #13

New issue
Closed
opened 2026-10-15 18:08:19 +00:00 by bsakaguchi · 0 comments
bsakaguchi commented 2026-10-15 18:08:19 +00:00
Owner
Copy link

📋 Pull Request Information

Original PR: https://github.com/SillyTavern/SillyTavern-WebSearch-Selenium/pull/6
Author: @NXTler
Created: 4/4/2025
Status: ✅ Merged
Merged: 4/6/2025
Merged by: @Cohee1207

Base: main ← Head: linklimit

📝 Commits (6)

  • 5cc3df7 Initial fix
  • 7a2af55 Utilize CamelCase for link_target
  • 5d10a8f Reorginization + Fixing slow loading issues
  • 2c41519 Fix getting page height + other
  • 2d9395f Update Build
  • 9a8879c Refactor utilities, rename linksTarget to maxLinks

📊 Changes

2 files changed (+39 additions, -11 deletions)

View changed files

📝 dist/plugin.js (+1 -1)
📝 src/index.ts (+38 -10)

📄 Description

Greetings,
this is a small commit to partially fix my issue I opened a while ago: https://github.com/SillyTavern/Extension-WebSearch/issues/10
The implementation for Google is done through the &num= search parameter and hence is limited to 100 links. I kept the implementation this basic, because I'm not able to perform any web search tests with Google due to bot recognition.
This limitation could be lifted in the future by utilizing the &start= search parameter and repeatedly append new links from every page until the target is reached.

DuckDuckGo's implementation has no limitation to how many links it can find, and uses a scrolling hack to load more results. It also includes some additional search parameters to speed up loading time (discussed in the issue mentioned above). Some Debug messages could be included for DuckDuckGo, if for example Selenium ran out of attempts before reaching the target, but I'm not too familiar with this project and don't know what could actually be useful here.

Feedback would be appreciated.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/SillyTavern/SillyTavern-WebSearch-Selenium/pull/6 **Author:** [@NXTler](https://github.com/NXTler) **Created:** 4/4/2025 **Status:** ✅ Merged **Merged:** 4/6/2025 **Merged by:** [@Cohee1207](https://github.com/Cohee1207) **Base:** `main` ← **Head:** `linklimit` --- ### 📝 Commits (6) - [`5cc3df7`](https://github.com/SillyTavern/SillyTavern-WebSearch-Selenium/commit/5cc3df7d230df6374c55dd1929510d3206927986) Initial fix - [`7a2af55`](https://github.com/SillyTavern/SillyTavern-WebSearch-Selenium/commit/7a2af558ff8b91b475cf504ebdbc460e381596ee) Utilize CamelCase for link_target - [`5d10a8f`](https://github.com/SillyTavern/SillyTavern-WebSearch-Selenium/commit/5d10a8f583144c6d2432ac464b26343af3e3dd9a) Reorginization + Fixing slow loading issues - [`2c41519`](https://github.com/SillyTavern/SillyTavern-WebSearch-Selenium/commit/2c41519284b6d1075caab37339a3ab22c66419ce) Fix getting page height + other - [`2d9395f`](https://github.com/SillyTavern/SillyTavern-WebSearch-Selenium/commit/2d9395f303e2fb848577da3c6663da03f5e9779f) Update Build - [`9a8879c`](https://github.com/SillyTavern/SillyTavern-WebSearch-Selenium/commit/9a8879c01b08423f94ef205125f7a836bd0bbe7c) Refactor utilities, rename linksTarget to maxLinks ### 📊 Changes **2 files changed** (+39 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `dist/plugin.js` (+1 -1) 📝 `src/index.ts` (+38 -10) </details> ### 📄 Description Greetings, this is a small commit to partially fix my issue I opened a while ago: https://github.com/SillyTavern/Extension-WebSearch/issues/10 The implementation for Google is done through the `&num=` search parameter and hence is limited to 100 links. I kept the implementation this basic, because I'm not able to perform any web search tests with Google due to bot recognition. This limitation could be lifted in the future by utilizing the `&start=` search parameter and repeatedly append new links from every page until the target is reached. DuckDuckGo's implementation has no limitation to how many links it can find, and uses a scrolling hack to load more results. It also includes some additional search parameters to speed up loading time (discussed in the issue mentioned above). Some Debug messages could be included for DuckDuckGo, if for example Selenium ran out of attempts before reaching the target, but I'm not too familiar with this project and don't know what could actually be useful here. Feedback would be appreciated. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
bsakaguchi 2026-10-15 18:08:19 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
dependabot/npm_and_yarn/npm_and_yarn-5a0513363d
env-vars
No results found.
Labels
Clear labels   
pull-request
Mirrored from GitHub Pull Request

No labels
pull-request
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
SillyTavern/SillyTavern-WebSearch-Selenium#13
No description provided.