From 328b4f8872b4bca9a53d2de8c6e285f3eb13d196 Mon Sep 17 00:00:00 2001 From: Devin Matthews Date: Wed, 30 Dec 2020 17:54:18 -0600 Subject: [PATCH] Shared object (dylib) was not built correctly for partial build. The SO build rule used $? instead of $^. Observed on macOS, not sure if it affected Linux or not. --- Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 17bf6c369..86a33f423 100644 --- a/Makefile +++ b/Makefile @@ -651,7 +651,7 @@ ifeq ($(ARG_MAX_HACK),yes) $(LINKER) $(SOFLAGS) -o $(LIBBLIS_SO_OUTPUT_NAME) @$@.in $(LDFLAGS) $(RM_F) $@.in else - $(LINKER) $(SOFLAGS) -o $(LIBBLIS_SO_OUTPUT_NAME) $? $(LDFLAGS) + $(LINKER) $(SOFLAGS) -o $(LIBBLIS_SO_OUTPUT_NAME) $^ $(LDFLAGS) endif else # ifeq ($(ENABLE_VERBOSE),no) ifeq ($(ARG_MAX_HACK),yes) @@ -661,7 +661,7 @@ ifeq ($(ARG_MAX_HACK),yes) @$(RM_F) $@.in else @echo "Dynamically linking $@" - @$(LINKER) $(SOFLAGS) -o $(LIBBLIS_SO_OUTPUT_NAME) $? $(LDFLAGS) + @$(LINKER) $(SOFLAGS) -o $(LIBBLIS_SO_OUTPUT_NAME) $^ $(LDFLAGS) endif endif