amd/blis
1
0
Fork 0
mirror of https://github.com/amd/blis.git synced 2026-05-11 09:39:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fixed bli_get_range_*() bugs in trsm variants.

Browse Source 
Details:
- Fixed incorrect calls to bli_get_range_*() from within trsm blocked
  variants 1f, 2b, and 2f. The bug somehow went undetected since the
  big commit (537a1f4), and, strangely, did not manifest via the BLIS
  testsuite. The bug finally came to our attention when running thei
  libflame test suite while linking to BLIS. Thanks to Kiran Varaganti
  for submitting the initial report that led to this bug.
This commit is contained in:
Field G. Van Zee
2016-05-11 16:09:49 -05:00
parent 9cfa33023f
commit 4bcf1b35ab
3 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
frame/3/trsm/bli_trsm_blk_var1f.c
View File

@@ -74,7 +74,7 @@ void bli_trsm_blk_var1f( obj_t* a,
trsm_thread_sub_opackm( thread ) );
dim_t my_start, my_end;
bli_get_range_b2t( thread, a,
bli_get_range_t2b( thread, a,
( bli_obj_root_is_triangular( *a ) ?
bli_cntx_get_bmult( BLIS_MR, cntx ) :
bli_cntx_get_bmult( BLIS_NR, cntx ) ),

4
frame/3/trsm/bli_trsm_blk_var2b.c
View File

@@ -84,8 +84,8 @@ void bli_trsm_blk_var2b( obj_t* a,
trsm_thread_sub_opackm( thread ) );
dim_t my_start, my_end;
bli_get_range_b2t( thread, a,
( bli_obj_root_is_triangular( *a ) ?
bli_get_range_r2l( thread, b,
( bli_obj_root_is_triangular( *b ) ?
bli_cntx_get_bmult( BLIS_MR, cntx ) :
bli_cntx_get_bmult( BLIS_NR, cntx ) ),
&my_start, &my_end );

4
frame/3/trsm/bli_trsm_blk_var2f.c
View File

@@ -84,8 +84,8 @@ void bli_trsm_blk_var2f( obj_t* a,
trsm_thread_sub_opackm( thread ) );
dim_t my_start, my_end;
bli_get_range_b2t( thread, a,
( bli_obj_root_is_triangular( *a ) ?
bli_get_range_l2r( thread, b,
( bli_obj_root_is_triangular( *b ) ?
bli_cntx_get_bmult( BLIS_MR, cntx ) :
bli_cntx_get_bmult( BLIS_NR, cntx ) ),
&my_start, &my_end );