From d10e05bbd1ce45ce2c0dfe5c64daae2633357b3f Mon Sep 17 00:00:00 2001 From: "Field G. Van Zee" Date: Sun, 13 Jun 2021 19:36:16 -0500 Subject: [PATCH] Sandbox header edits trigger full library rebuild. Details: - Adjusted the top-level Makefile so that any change to a sandbox header file will result in blis.h being regenerated along with a full recompilation of the library. Previously, sandbox files were omitted from the list of header files that, when touched, could trigger a full rebuild. Why was it like that previously? Because originally we only envisioned using sandboxes to *replace* gemm, not augment the library with new functionality. When replacing gemm, blis.h does not need to contain any local sandbox defintions in order for the user to be able to (indirectly) use that sandbox. But if you are adding functions to the library, those functions need to be prototyped so the compiler can perform type checking against the user's invocation of those new functions. Thanks to Jeff Diamond for helping us discover this deficiency in the build system. --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index e8793964f..9a69fca8b 100644 --- a/Makefile +++ b/Makefile @@ -461,7 +461,7 @@ endif flat-header: check-env $(BLIS_H_FLAT) -$(BLIS_H_FLAT): $(FRAME_H99_FILES) +$(BLIS_H_FLAT): $(ALL_H99_FILES) ifeq ($(ENABLE_VERBOSE),yes) $(FLATTEN_H) -c -v1 $(BLIS_H_SRC_PATH) $@ "./$(INCLUDE_DIR)" "$(ALL_H99_DIRPATHS)" else