amd/blis
1
0
Fork 0
mirror of https://github.com/amd/blis.git synced 2026-04-20 07:38:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

Replaced use of bool_t type with C99 bool.

Browse Source 
Details:
- Textually replaced nearly all non-comment instances of bool_t with the
  C99 bool type. A few remaining instances, such as those in the files
  bli_herk_x_ker_var2.c, bli_trmm_xx_ker_var2.c, and
  bli_trsm_xx_ker_var2.c, were promoted to dim_t since they were being
  used not for boolean purposes but to index into an array.
- This commit constitutes the third phase of a transition toward using
  C99's bool instead of bool_t, which was raised in issue #420. The first
  phase, which cleaned up various typecasts in preparation for using
  bool as the basis for bool_t (instead of gint_t), was implemented by
  commit a69a4d7. The second phase, which redefined the bool_t typedef
  in terms of bool (from gint_t), was implemented by commit 2c554c2.
This commit is contained in:
Field G. Van Zee
2020-07-29 14:24:34 -05:00
committed by dzambare
parent 14d95a2183
commit fd5db714f4
164 changed files with 908 additions and 908 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
docs/CodingConventions.md
View File

@@ -54,9 +54,9 @@ Please either use braces to denote the indentation limits of scope, or to enclos
If at all possible, **please use tabs to denote changing levels of scope!** If you can't use tabs or doing so would be very inconvenient given your editor and setup, please set your indentation to use exactly four spaces per level of indentation. Below is what it would look like if you used tabs (with a tab width set to occupy four spaces), or four actual spaces per indentation level.
```c
bool_t bli_obj_is_real( obj_t* x )
bool bli_obj_is_real( obj_t* x )
{
bool_t r_val;
bool r_val;
if ( bli_obj_is_real( x ) )
r_val = TRUE;
@@ -67,9 +67,9 @@ bool_t bli_obj_is_real( obj_t* x )
Ideally, tabs should be used to indicate changes in levels of scope, but then spaces should be used for multi-line statements within the same scope. In the example below, I've marked the characters that should be spaces with `.` (with tabs used for the first level of indentation):
```c
bool_t bli_obj_is_complex( obj_t* x )
bool bli_obj_is_complex( obj_t* x )
{
bool_t r_val;
bool r_val;
if ( bli_obj_is_scomplex( x ) ||
.....bli_obj_is_dcomplex( x ) ) r_val = TRUE;
@@ -123,8 +123,8 @@ Please use blank lines to separate lines of code from the next line of code. How
Sometimes, to more efficiently display code on the screen, it's helpful to skip certain newlines, such as those in conditional statements. This is fine, just try to line things up in a way that is visually appealing.
```c
{
bool_t r_val;
dim_t foo;
bool r_val;
dim_t foo;
// This is fine.
if ( bli_obj_is_real( x ) ) r_val = TRUE;