mirror of
https://github.com/amd/blis.git
synced 2026-04-29 20:11:12 +00:00
Details: - Fixed a bug that broke the use of 1m for dcomplex when the single- precision real and double-precision real ukernels had opposing I/O preferences (row-preferential sgemm ukernel + column-preferential dgemm ukernel, or vice versa). The fix involved adjusting the API to bli_cntx_set_ind_blkszs() so that the induced method context init function (e.g., bli_cntx_init_<subconfig>_ind()) could call that function for only one datatype at a time. This allowed the blocksize scaling (which varies depending on whether we're doing 1m_r or 1m_c) to happen on a per-datatype basis. This fixes issue #557. Thanks to Devin Matthews and RuQing Xu for helping discover and report this bug. - The aforementioned 1m fix required moving the 1m_r/1m_c logic from bli_cntx_ref.c into a new function, bli_l3_set_schemas(), which is called from each level-3 _front() function. The pack_t schemas in the cntx_t were also removed entirely, along with the associated accessor functions. This in turn required updating the trsm1m-related virtual ukernels to read the pack schema for B from the auxinfo_t struct rather than the context. This also required slight tweaks to bli_gemm_md.c. - Repositioned the logic for transposing the operation to accommodate the microkernel IO preference. This mostly only affects gemm. Thanks to Devin Matthews for his help with this. - Updated dpackm pack ukernels in the 'armsve' kernel set to avoid querying pack_t schemas from the context. - Removed the num_t dt argument from the ind_cntx_init_ft type defined in bli_gks.c. The context initialization functions for induced methods were previously passed a dt argument, but I can no longer figure out *why* they were passed this value. To reduce confusion, I've removed the dt argument (including also from the function defintion + prototype). - Commented out setting of cntx_t schemas in bli_cntx_ind_stage.c. This breaks high-leve implementations of 3m and 4m, but this is okay since those implementations will be removed very soon. - Removed some older blocks of preprocessor-disabled code. - Comment update to test_libblis.c.
190 lines
6.9 KiB
C
190 lines
6.9 KiB
C
/*
|
|
|
|
BLIS
|
|
An object-based framework for developing high-performance BLAS-like
|
|
libraries.
|
|
|
|
Copyright (C) 2014, The University of Texas at Austin
|
|
Copyright (C) 2018 - 2019, Advanced Micro Devices, Inc.
|
|
|
|
Redistribution and use in source and binary forms, with or without
|
|
modification, are permitted provided that the following conditions are
|
|
met:
|
|
- Redistributions of source code must retain the above copyright
|
|
notice, this list of conditions and the following disclaimer.
|
|
- Redistributions in binary form must reproduce the above copyright
|
|
notice, this list of conditions and the following disclaimer in the
|
|
documentation and/or other materials provided with the distribution.
|
|
- Neither the name(s) of the copyright holder(s) nor the names of its
|
|
contributors may be used to endorse or promote products derived
|
|
from this software without specific prior written permission.
|
|
|
|
THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
|
|
"AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
|
|
LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
|
|
A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
|
|
HOLDER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
|
|
SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
|
|
LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
|
|
DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
|
|
THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
|
|
(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
|
|
OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
|
|
*/
|
|
|
|
#include "blis.h"
|
|
|
|
void bli_trmm_front
|
|
(
|
|
side_t side,
|
|
obj_t* alpha,
|
|
obj_t* a,
|
|
obj_t* b,
|
|
cntx_t* cntx,
|
|
rntm_t* rntm,
|
|
cntl_t* cntl
|
|
)
|
|
{
|
|
bli_init_once();
|
|
|
|
obj_t a_local;
|
|
obj_t b_local;
|
|
obj_t c_local;
|
|
|
|
// Check parameters.
|
|
if ( bli_error_checking_is_enabled() )
|
|
bli_trmm_check( side, alpha, a, b, &BLIS_ZERO, b, cntx );
|
|
|
|
// If alpha is zero, scale by beta and return.
|
|
if ( bli_obj_equals( alpha, &BLIS_ZERO ) )
|
|
{
|
|
bli_scalm( alpha, b );
|
|
return;
|
|
}
|
|
|
|
// Alias A and B so we can tweak the objects if necessary.
|
|
bli_obj_alias_to( a, &a_local );
|
|
bli_obj_alias_to( b, &b_local );
|
|
bli_obj_alias_to( b, &c_local );
|
|
|
|
// We do not explicitly implement the cases where A is transposed.
|
|
// However, we can still handle them. Specifically, if A is marked as
|
|
// needing a transposition, we simply induce a transposition. This
|
|
// allows us to only explicitly implement the no-transpose cases. Once
|
|
// the transposition is induced, the correct algorithm will be called,
|
|
// since, for example, an algorithm over a transposed lower triangular
|
|
// matrix A moves in the same direction (forwards) as a non-transposed
|
|
// upper triangular matrix. And with the transposition induced, the
|
|
// matrix now appears to be upper triangular, so the upper triangular
|
|
// algorithm will grab the correct partitions, as if it were upper
|
|
// triangular (with no transpose) all along.
|
|
if ( bli_obj_has_trans( &a_local ) )
|
|
{
|
|
bli_obj_induce_trans( &a_local );
|
|
bli_obj_set_onlytrans( BLIS_NO_TRANSPOSE, &a_local );
|
|
}
|
|
|
|
#ifdef BLIS_DISABLE_TRMM_RIGHT
|
|
// NOTE: This case casts right-side trmm in terms of left side. This is
|
|
// necessary when the current subconfiguration uses a gemm microkernel
|
|
// that assumes that the packing kernel will have already duplicated
|
|
// (broadcast) element of B in the packed copy of B. Supporting
|
|
// duplication within the logic that packs micropanels from triangular
|
|
// matrices would be ugly, and so we simply don't support it. As a
|
|
// consequence, those subconfigurations need a way to force the triangular
|
|
// matrix to be on the left (and thus the general matrix to the on the
|
|
// right). So our solution is that in those cases, the subconfigurations
|
|
// simply #define BLIS_DISABLE_TRMM_RIGHT.
|
|
|
|
// NOTE: This case casts right-side trmm in terms of left side. This can
|
|
// lead to the microkernel being executed on an output matrix with the
|
|
// microkernel's general stride IO case (unless the microkernel supports
|
|
// both both row and column IO cases as well).
|
|
|
|
// NOTE: Casting right-side trmm in terms of left side reduces the number
|
|
// of macrokernels exercised to two (trmm_ll and trmm_lu).
|
|
|
|
// If A is being multiplied from the right, transpose all operands
|
|
// so that we can perform the computation as if A were being multiplied
|
|
// from the left.
|
|
if ( bli_is_right( side ) )
|
|
{
|
|
bli_toggle_side( &side );
|
|
bli_obj_induce_trans( &a_local );
|
|
bli_obj_induce_trans( &b_local );
|
|
bli_obj_induce_trans( &c_local );
|
|
}
|
|
|
|
#else
|
|
// NOTE: This case computes right-side trmm natively with trmm_rl and
|
|
// trmm_ru macrokernels. This code path always gives us the opportunity
|
|
// to transpose the entire operation so that the effective storage format
|
|
// of the output matrix matches the microkernel's output preference.
|
|
// Thus, from a performance perspective, this case is preferred.
|
|
|
|
// An optimization: If C is stored by rows and the micro-kernel prefers
|
|
// contiguous columns, or if C is stored by columns and the micro-kernel
|
|
// prefers contiguous rows, transpose the entire operation to allow the
|
|
// micro-kernel to access elements of C in its preferred manner.
|
|
// NOTE: We disable the optimization for 1x1 matrices since the concept
|
|
// of row- vs. column storage breaks down.
|
|
//if ( !bli_obj_is_1x1( &c_local ) ) // NOTE: This conditional should NOT
|
|
// be enabled. See issue #342 comments.
|
|
if ( bli_cntx_l3_vir_ukr_dislikes_storage_of( &c_local, BLIS_GEMM_UKR, cntx ) )
|
|
{
|
|
bli_toggle_side( &side );
|
|
bli_obj_induce_trans( &a_local );
|
|
bli_obj_induce_trans( &b_local );
|
|
bli_obj_induce_trans( &c_local );
|
|
}
|
|
|
|
// If A is being multiplied from the right, swap A and B so that
|
|
// the matrix will actually be on the right.
|
|
if ( bli_is_right( side ) )
|
|
{
|
|
bli_obj_swap( &a_local, &b_local );
|
|
}
|
|
|
|
#endif
|
|
|
|
// Set the pack schemas within the objects.
|
|
bli_l3_set_schemas( &a_local, &b_local, &c_local, cntx );
|
|
|
|
// Set each alias as the root object.
|
|
// NOTE: We MUST wait until we are done potentially swapping the objects
|
|
// before setting the root fields!
|
|
bli_obj_set_as_root( &a_local );
|
|
bli_obj_set_as_root( &b_local );
|
|
bli_obj_set_as_root( &c_local );
|
|
|
|
// Parse and interpret the contents of the rntm_t object to properly
|
|
// set the ways of parallelism for each loop, and then make any
|
|
// additional modifications necessary for the current operation.
|
|
bli_rntm_set_ways_for_op
|
|
(
|
|
BLIS_TRMM,
|
|
side,
|
|
bli_obj_length( &c_local ),
|
|
bli_obj_width( &c_local ),
|
|
bli_obj_width( &a_local ),
|
|
rntm
|
|
);
|
|
|
|
// Invoke the internal back-end.
|
|
bli_l3_thread_decorator
|
|
(
|
|
bli_gemm_int,
|
|
BLIS_TRMM, // operation family id
|
|
alpha,
|
|
&a_local,
|
|
&b_local,
|
|
&BLIS_ZERO,
|
|
&c_local,
|
|
cntx,
|
|
rntm,
|
|
cntl
|
|
);
|
|
}
|
|
|