[PR #2] Read Windows build version from CMake #3

Open
opened 2026-10-13 20:07:30 +00:00 by bsakaguchi · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/amnezia-vpn/amnezia-client-copy/pull/2
Author: @pokamest
Created: 6/7/2025
Status: 🔄 Open

Base: dev ← Head: codex/доработать-скрипт-сборки-для-msi-инсталлятора


📝 Commits (5)

📊 Changes

6 files changed (+47 additions, -2 deletions)

View changed files

📝 .github/workflows/deploy.yml (+6 -1)
📝 README.md (+1 -0)
📝 README_RU.md (+1 -0)
📝 deploy/build_windows.bat (+16 -1)
➕ deploy/installer/wix/Product.wxs (+11 -0)
➕ deploy/installer/wix/Service.wxs (+12 -0)

📄 Description

Summary

  • drop hard-coded APP_VERSION from the Windows build script
  • read the version from CMake-generated client/version.h

Testing

  • git status --short

https://chatgpt.com/codex/tasks/task_e_68437bf45e608333916736a153280cd4


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/amnezia-vpn/amnezia-client-copy/pull/2 **Author:** [@pokamest](https://github.com/pokamest) **Created:** 6/7/2025 **Status:** 🔄 Open **Base:** `dev` ← **Head:** `codex/доработать-скрипт-сборки-для-msi-инсталлятора` --- ### 📝 Commits (5) - [`b801033`](https://github.com/amnezia-vpn/amnezia-client-copy/commit/b801033de5ea49ba453d0b39a298f394e95cfc8b) Get Windows build version from CMake - [`bfa7d7f`](https://github.com/amnezia-vpn/amnezia-client-copy/commit/bfa7d7f24a2e035162885897f7c23856f22db133) Update README.md - [`ce4482c`](https://github.com/amnezia-vpn/amnezia-client-copy/commit/ce4482c776b960a2ed5d1269a92bb1e7d6a27a31) Update deploy.yml - [`4bfbf30`](https://github.com/amnezia-vpn/amnezia-client-copy/commit/4bfbf30137aaa116a5748a457aa5b77b9f575929) Update deploy.yml - [`99735c5`](https://github.com/amnezia-vpn/amnezia-client-copy/commit/99735c5d42f66541eb43ad5c20881ae98922d617) Fix Windows MSI build ### 📊 Changes **6 files changed** (+47 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/deploy.yml` (+6 -1) 📝 `README.md` (+1 -0) 📝 `README_RU.md` (+1 -0) 📝 `deploy/build_windows.bat` (+16 -1) ➕ `deploy/installer/wix/Product.wxs` (+11 -0) ➕ `deploy/installer/wix/Service.wxs` (+12 -0) </details> ### 📄 Description ## Summary - drop hard-coded `APP_VERSION` from the Windows build script - read the version from CMake-generated `client/version.h` ## Testing - `git status --short` ------ https://chatgpt.com/codex/tasks/task_e_68437bf45e608333916736a153280cd4 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Sign in to join this conversation.
No labels
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
amnezia-vpn/amnezia-client-copy#3
No description provided.