[PR #144] [MERGED] refactoring/logging #1614

Closed
opened 2026-10-13 20:45:58 +00:00 by bsakaguchi · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/amnezia-vpn/amnezia-client/pull/144
Author: @Nethius
Created: 12/28/2022
Status: ✅ Merged
Merged: 1/16/2023
Merged by: @pokamest

Base: qt_migration ← Head: refactoring/logging


📝 Commits (8)

  • ce4ca5c Added display of a notification about the inclusion of logging on the main screen
  • 195663c Added activation and deactivation of logging without restarting the application
  • 77e51b4 removed unused logger
  • 3b2948d renamed debug class to logger
  • 686fc75 renamed log class in service project to logger
  • b1b9044 Merge branch 'qt_migration' into refactoring/logging
  • 6e88276 Merge branch 'qt_migration' into refactoring/logging
  • 44d2627 Tiny fix [no ci]

📊 Changes

28 files changed (+289 additions, -855 deletions)

View changed files

📝 client/amnezia_application.cpp (+4 -4)
📝 client/client.pro (+2 -7)
📝 client/core/servercontroller.cpp (+4 -4)
📝 client/core/servercontroller.h (+1 -1)
➖ client/debug.cpp (+0 -173)
➖ client/debug.h (+0 -50)
📝 client/logger.cpp (+165 -42)
📝 client/logger.h (+33 -72)
➖ client/loghandler.cpp (+0 -345)
➖ client/loghandler.h (+0 -102)
➖ client/loglevel.h (+0 -15)
📝 client/protocols/ikev2_vpn_protocol_windows.cpp (+1 -1)
📝 client/protocols/openvpnprotocol.cpp (+1 -1)
📝 client/protocols/shadowsocksvpnprotocol.cpp (+1 -1)
📝 client/protocols/wireguardprotocol.cpp (+1 -1)
📝 client/settings.cpp (+14 -0)
📝 client/settings.h (+4 -1)
📝 client/ui/pages_logic/AppSettingsLogic.cpp (+5 -5)
📝 client/ui/pages_logic/VpnLogic.cpp (+4 -0)
📝 client/ui/pages_logic/VpnLogic.h (+2 -0)

...and 8 more files

📄 Description

small logging refactoring:

  • Added display of a notification about the inclusion of logging on the main screen
  • Added activation and deactivation of logging without restarting the application
  • Removed unused mozila logger
  • Renamed debug class in client project to logger
  • Renamed log class in service project to logger

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/amnezia-vpn/amnezia-client/pull/144 **Author:** [@Nethius](https://github.com/Nethius) **Created:** 12/28/2022 **Status:** ✅ Merged **Merged:** 1/16/2023 **Merged by:** [@pokamest](https://github.com/pokamest) **Base:** `qt_migration` ← **Head:** `refactoring/logging` --- ### 📝 Commits (8) - [`ce4ca5c`](https://github.com/amnezia-vpn/amnezia-client/commit/ce4ca5c4d5ceb3a465e3c3038f1c7692b215f603) Added display of a notification about the inclusion of logging on the main screen - [`195663c`](https://github.com/amnezia-vpn/amnezia-client/commit/195663c6e36e7ea86586a8a5bced6246d75015ae) Added activation and deactivation of logging without restarting the application - [`77e51b4`](https://github.com/amnezia-vpn/amnezia-client/commit/77e51b40b8f01b8866234687fbfe9ad02a60bd15) removed unused logger - [`3b2948d`](https://github.com/amnezia-vpn/amnezia-client/commit/3b2948d4dde81ee8fcb9946fda55fdb308690f76) renamed debug class to logger - [`686fc75`](https://github.com/amnezia-vpn/amnezia-client/commit/686fc754b2878f407d3da432de9369c9cb183f7b) renamed log class in service project to logger - [`b1b9044`](https://github.com/amnezia-vpn/amnezia-client/commit/b1b9044021504ea0d0e6755c2b9f8edfecb60f99) Merge branch 'qt_migration' into refactoring/logging - [`6e88276`](https://github.com/amnezia-vpn/amnezia-client/commit/6e882760f12ed648b187f4a28cd35e97efc0758f) Merge branch 'qt_migration' into refactoring/logging - [`44d2627`](https://github.com/amnezia-vpn/amnezia-client/commit/44d2627e2a08d6444e3d7b0408a05c36bc32ace8) Tiny fix [no ci] ### 📊 Changes **28 files changed** (+289 additions, -855 deletions) <details> <summary>View changed files</summary> 📝 `client/amnezia_application.cpp` (+4 -4) 📝 `client/client.pro` (+2 -7) 📝 `client/core/servercontroller.cpp` (+4 -4) 📝 `client/core/servercontroller.h` (+1 -1) ➖ `client/debug.cpp` (+0 -173) ➖ `client/debug.h` (+0 -50) 📝 `client/logger.cpp` (+165 -42) 📝 `client/logger.h` (+33 -72) ➖ `client/loghandler.cpp` (+0 -345) ➖ `client/loghandler.h` (+0 -102) ➖ `client/loglevel.h` (+0 -15) 📝 `client/protocols/ikev2_vpn_protocol_windows.cpp` (+1 -1) 📝 `client/protocols/openvpnprotocol.cpp` (+1 -1) 📝 `client/protocols/shadowsocksvpnprotocol.cpp` (+1 -1) 📝 `client/protocols/wireguardprotocol.cpp` (+1 -1) 📝 `client/settings.cpp` (+14 -0) 📝 `client/settings.h` (+4 -1) 📝 `client/ui/pages_logic/AppSettingsLogic.cpp` (+5 -5) 📝 `client/ui/pages_logic/VpnLogic.cpp` (+4 -0) 📝 `client/ui/pages_logic/VpnLogic.h` (+2 -0) _...and 8 more files_ </details> ### 📄 Description small logging refactoring: - Added display of a notification about the inclusion of logging on the main screen - Added activation and deactivation of logging without restarting the application - Removed unused mozila logger - Renamed debug class in client project to logger - Renamed log class in service project to logger --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
bsakaguchi 2026-10-13 20:45:58 +00:00
Sign in to join this conversation.
No labels
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
amnezia-vpn/amnezia-client#1614
No description provided.