[PR #193] [MERGED] iOS - libssh with mbedtls build #1655

Closed
opened 2026-10-13 20:46:28 +00:00 by bsakaguchi · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/amnezia-vpn/amnezia-client/pull/193
Author: @bakhtiyork
Created: 3/24/2023
Status: ✅ Merged
Merged: 4/6/2023
Merged by: @pokamest

Base: feature/qt6-libssh-support ← Head: feature/qt6-libssh-support


📝 Commits (4)

  • 698dfb6 iOS - libssh with mbedtls build
  • fe9e813 Custom cmake module path
  • ef03a3d FindMbedTLS.cmake - adding mbedtls targets export
  • f931603 Disabling symbol versioning for iOS

📊 Changes

5 files changed (+94 additions, -42 deletions)

View changed files

📝 .gitmodules (+3 -0)
➕ client/3rd/mbedtls (+1 -0)
📝 client/CMakeLists.txt (+0 -1)
📝 client/cmake/3rdparty.cmake (+65 -41)
➕ client/cmake/Modules/FindMbedTLS.cmake (+25 -0)

📄 Description

No additional actions required.
There are few steps required to make libssh compile:

  1. Edit client/3rd/libssh/src/CMakeLists.txt:
    • comment out line 372
    • comment out lines 402-403
  2. Edit client/3rd/libssh/cmake/Modules/FindMbedTLS.cmake
    • replace lines 72-73 with "set(MBEDTLS_LIBRARIES mbedtls mbedcrypto mbedx509)"
    • add at line 102 - "include_directories(${MBEDTLS_INCLUDE_DIR})"

I'm working on making libssh build smooth without need to manual edit files.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/amnezia-vpn/amnezia-client/pull/193 **Author:** [@bakhtiyork](https://github.com/bakhtiyork) **Created:** 3/24/2023 **Status:** ✅ Merged **Merged:** 4/6/2023 **Merged by:** [@pokamest](https://github.com/pokamest) **Base:** `feature/qt6-libssh-support` ← **Head:** `feature/qt6-libssh-support` --- ### 📝 Commits (4) - [`698dfb6`](https://github.com/amnezia-vpn/amnezia-client/commit/698dfb67d11982defa2dc18a607a3ee63663bf34) iOS - libssh with mbedtls build - [`fe9e813`](https://github.com/amnezia-vpn/amnezia-client/commit/fe9e813c799880cd4d0583aef75030085227a892) Custom cmake module path - [`ef03a3d`](https://github.com/amnezia-vpn/amnezia-client/commit/ef03a3d9d4b3c1c8649af75b30c027c2f91579b3) FindMbedTLS.cmake - adding mbedtls targets export - [`f931603`](https://github.com/amnezia-vpn/amnezia-client/commit/f931603203937122ecd2077e04b1f504b5e1cc61) Disabling symbol versioning for iOS ### 📊 Changes **5 files changed** (+94 additions, -42 deletions) <details> <summary>View changed files</summary> 📝 `.gitmodules` (+3 -0) ➕ `client/3rd/mbedtls` (+1 -0) 📝 `client/CMakeLists.txt` (+0 -1) 📝 `client/cmake/3rdparty.cmake` (+65 -41) ➕ `client/cmake/Modules/FindMbedTLS.cmake` (+25 -0) </details> ### 📄 Description No additional actions required. ~~There are few steps required to make libssh compile:~~ 1. ~~Edit client/3rd/libssh/src/CMakeLists.txt:~~ * ~~comment out line 372~~ * ~~comment out lines 402-403~~ 2. ~~Edit client/3rd/libssh/cmake/Modules/FindMbedTLS.cmake~~ * ~~replace lines 72-73 with "set(MBEDTLS_LIBRARIES mbedtls mbedcrypto mbedx509)"~~ * ~~add at line 102 - "include_directories(${MBEDTLS_INCLUDE_DIR})"~~ I'm working on making libssh build smooth without need to manual edit files. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
bsakaguchi 2026-10-13 20:46:28 +00:00
Sign in to join this conversation.
No labels
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
amnezia-vpn/amnezia-client#1655
No description provided.