[PR #352] [MERGED] Limit Drawer positioning by dragHeight and total page height #1770

New issue

Closed

opened 2026-10-13 20:47:56 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-13 20:47:56 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/amnezia-vpn/amnezia-client/pull/352
Author: @MattSchwiebert
Created: 9/28/2023
Status: ✅ Merged
Merged: 10/3/2023
Merged by: @Nethius

Base: dev ← Head: fix/drawerTypePositioning

📝 Commits (7)

058f8b5 Limit Drawer positioning by dragHeight and total page height
3d999a5 Add custom drawer behavior to pageHome, for mobile and desktop
a6134ca fix visibility bug of collapsed state
5bfc581 add documentation, remove uneeded changes of drawertype
617e772 added transitions and open/close by clicking on an item for the center menu button
b1e9e86 Merge branch 'fix/drawerTypePositioning' of github.com:amnezia-vpn/amnezia-client into fix/drawerTypePositioning
52124b1 Merge branch 'dev' of github.com:amnezia-vpn/amnezia-client into fix/drawerTypePositioning

📊 Changes

4 files changed (+196 additions, -206 deletions)

View changed files

📝 client/resources.qrc (+0 -1)
➖ client/ui/qml/Components/HomeRootMenuButton.qml (+0 -140)
📝 client/ui/qml/Controls2/DrawerType.qml (+0 -28)
📝 client/ui/qml/Pages2/PageHome.qml (+196 -37)

📄 Description

DrawerType will now begin open at dragMargin, as long as pageHeight is defined

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/amnezia-vpn/amnezia-client/pull/352 **Author:** [@MattSchwiebert](https://github.com/MattSchwiebert) **Created:** 9/28/2023 **Status:** ✅ Merged **Merged:** 10/3/2023 **Merged by:** [@Nethius](https://github.com/Nethius) **Base:** `dev` ← **Head:** `fix/drawerTypePositioning` --- ### 📝 Commits (7) - [`058f8b5`](https://github.com/amnezia-vpn/amnezia-client/commit/058f8b544e5c16dd6128bc54d3d9c57d645e4785) Limit Drawer positioning by dragHeight and total page height - [`3d999a5`](https://github.com/amnezia-vpn/amnezia-client/commit/3d999a503c865402cd38c22713071e001cc4f614) Add custom drawer behavior to pageHome, for mobile and desktop - [`a6134ca`](https://github.com/amnezia-vpn/amnezia-client/commit/a6134ca10f0611fdb7c2522b24c589231cf79931) fix visibility bug of collapsed state - [`5bfc581`](https://github.com/amnezia-vpn/amnezia-client/commit/5bfc581ad2ba8bb10070ae769c33e6df0dd2b3fd) add documentation, remove uneeded changes of drawertype - [`617e772`](https://github.com/amnezia-vpn/amnezia-client/commit/617e772cc16ce843fec947b27c5479a717ed8f45) added transitions and open/close by clicking on an item for the center menu button - [`b1e9e86`](https://github.com/amnezia-vpn/amnezia-client/commit/b1e9e8677b7b60acd8eeaa658d9d7d2b12251cdc) Merge branch 'fix/drawerTypePositioning' of github.com:amnezia-vpn/amnezia-client into fix/drawerTypePositioning - [`52124b1`](https://github.com/amnezia-vpn/amnezia-client/commit/52124b15e888c64475add89940ceed79a172a776) Merge branch 'dev' of github.com:amnezia-vpn/amnezia-client into fix/drawerTypePositioning ### 📊 Changes **4 files changed** (+196 additions, -206 deletions) <details> <summary>View changed files</summary> 📝 `client/resources.qrc` (+0 -1) ➖ `client/ui/qml/Components/HomeRootMenuButton.qml` (+0 -140) 📝 `client/ui/qml/Controls2/DrawerType.qml` (+0 -28) 📝 `client/ui/qml/Pages2/PageHome.qml` (+196 -37) </details> ### 📄 Description DrawerType will now begin open at dragMargin, as long as pageHeight is defined --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-13 20:47:56 +00:00

closed this issue
added the
pull-request
label

No labels

pull-request

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

amnezia-vpn/amnezia-client#1770

No description provided.

Rows
Columns