[PR #370] [MERGED] added new drawer2type for replacing drawertype #1789

New issue

Closed

opened 2026-10-13 21:15:32 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-13 21:15:32 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/amnezia-vpn/amnezia-client/pull/370
Author: @ronoaer
Created: 10/14/2023
Status: ✅ Merged
Merged: 10/21/2023
Merged by: @ronoaer

Base: dev ← Head: feature/custom_drawer_component

📝 Commits (10+)

384ce98 added new drawer2type for replacing drawertype
8c18359 added transparent-background, for blocking clicked event
a75bd07 fixed the clicked event
d0f8358 removed invalid code, and fixed top button hidden-shown
29b4966 shown ConnectionTypeSelectionDrawer on top level alway
cb5c09d adapted questionDrawer
7cc0f39 adapted pagehome by new custom drawer type
03171e4 update background color and drag-effect, moved dulicated code
a83cd29 fixed the cursorShape, and some minor issues
c461e00 keeping parent's cusorshape and Drawer2Type's close-animation

📊 Changes

28 files changed (+620 additions, -257 deletions)

View changed files

📝 client/resources.qrc (+1 -0)
📝 client/ui/qml/Components/ConnectionTypeSelectionDrawer.qml (+5 -2)
📝 client/ui/qml/Components/HomeContainersListView.qml (+1 -1)
📝 client/ui/qml/Components/QuestionDrawer.qml (+7 -3)
📝 client/ui/qml/Components/SelectLanguageDrawer.qml (+6 -2)
📝 client/ui/qml/Components/ShareConnectionDrawer.qml (+20 -7)
➕ client/ui/qml/Controls2/Drawer2Type.qml (+314 -0)
📝 client/ui/qml/Controls2/DropDownType.qml (+16 -5)
📝 client/ui/qml/Pages2/PageHome.qml (+120 -182)
📝 client/ui/qml/Pages2/PageProtocolCloakSettings.qml (+2 -0)
📝 client/ui/qml/Pages2/PageProtocolOpenVpnSettings.qml (+8 -3)
📝 client/ui/qml/Pages2/PageProtocolRaw.qml (+10 -5)
📝 client/ui/qml/Pages2/PageProtocolShadowSocksSettings.qml (+2 -0)
📝 client/ui/qml/Pages2/PageServiceDnsSettings.qml (+4 -3)
📝 client/ui/qml/Pages2/PageServiceSftpSettings.qml (+4 -3)
📝 client/ui/qml/Pages2/PageServiceTorWebsiteSettings.qml (+4 -3)
📝 client/ui/qml/Pages2/PageSettingsApplication.qml (+5 -3)
📝 client/ui/qml/Pages2/PageSettingsBackup.qml (+4 -3)
📝 client/ui/qml/Pages2/PageSettingsDns.qml (+4 -3)
📝 client/ui/qml/Pages2/PageSettingsLogging.qml (+4 -3)

...and 8 more files

📄 Description

No description provided

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/amnezia-vpn/amnezia-client/pull/370 **Author:** [@ronoaer](https://github.com/ronoaer) **Created:** 10/14/2023 **Status:** ✅ Merged **Merged:** 10/21/2023 **Merged by:** [@ronoaer](https://github.com/ronoaer) **Base:** `dev` ← **Head:** `feature/custom_drawer_component` --- ### 📝 Commits (10+) - [`384ce98`](https://github.com/amnezia-vpn/amnezia-client/commit/384ce9853b92b99f060a566257f1e0b701f9272d) added new drawer2type for replacing drawertype - [`8c18359`](https://github.com/amnezia-vpn/amnezia-client/commit/8c1835950bf64ebdf188769359bc908d501ba6d1) added transparent-background, for blocking clicked event - [`a75bd07`](https://github.com/amnezia-vpn/amnezia-client/commit/a75bd07cd8b604bbe5f6894ac8e861f57efe8df5) fixed the clicked event - [`d0f8358`](https://github.com/amnezia-vpn/amnezia-client/commit/d0f83584313d60c4c0507b60d5d78118ffb9cbdf) removed invalid code, and fixed top button hidden-shown - [`29b4966`](https://github.com/amnezia-vpn/amnezia-client/commit/29b4966119a57bb4631bb8ea289a5a27444471d6) shown ConnectionTypeSelectionDrawer on top level alway - [`cb5c09d`](https://github.com/amnezia-vpn/amnezia-client/commit/cb5c09d9679753785ecf3159e23a66bd877c9773) adapted questionDrawer - [`7cc0f39`](https://github.com/amnezia-vpn/amnezia-client/commit/7cc0f39d3ca12fd05fde3d7b6c06030d66e01c55) adapted pagehome by new custom drawer type - [`03171e4`](https://github.com/amnezia-vpn/amnezia-client/commit/03171e474331eec48be2717851a77359663c3139) update background color and drag-effect, moved dulicated code - [`a83cd29`](https://github.com/amnezia-vpn/amnezia-client/commit/a83cd29f725136094bfb5d8855b9167b761bb125) fixed the cursorShape, and some minor issues - [`c461e00`](https://github.com/amnezia-vpn/amnezia-client/commit/c461e00c5c378e5ed6ade5291b2233947a94fe60) keeping parent's cusorshape and Drawer2Type's close-animation ### 📊 Changes **28 files changed** (+620 additions, -257 deletions) <details> <summary>View changed files</summary> 📝 `client/resources.qrc` (+1 -0) 📝 `client/ui/qml/Components/ConnectionTypeSelectionDrawer.qml` (+5 -2) 📝 `client/ui/qml/Components/HomeContainersListView.qml` (+1 -1) 📝 `client/ui/qml/Components/QuestionDrawer.qml` (+7 -3) 📝 `client/ui/qml/Components/SelectLanguageDrawer.qml` (+6 -2) 📝 `client/ui/qml/Components/ShareConnectionDrawer.qml` (+20 -7) ➕ `client/ui/qml/Controls2/Drawer2Type.qml` (+314 -0) 📝 `client/ui/qml/Controls2/DropDownType.qml` (+16 -5) 📝 `client/ui/qml/Pages2/PageHome.qml` (+120 -182) 📝 `client/ui/qml/Pages2/PageProtocolCloakSettings.qml` (+2 -0) 📝 `client/ui/qml/Pages2/PageProtocolOpenVpnSettings.qml` (+8 -3) 📝 `client/ui/qml/Pages2/PageProtocolRaw.qml` (+10 -5) 📝 `client/ui/qml/Pages2/PageProtocolShadowSocksSettings.qml` (+2 -0) 📝 `client/ui/qml/Pages2/PageServiceDnsSettings.qml` (+4 -3) 📝 `client/ui/qml/Pages2/PageServiceSftpSettings.qml` (+4 -3) 📝 `client/ui/qml/Pages2/PageServiceTorWebsiteSettings.qml` (+4 -3) 📝 `client/ui/qml/Pages2/PageSettingsApplication.qml` (+5 -3) 📝 `client/ui/qml/Pages2/PageSettingsBackup.qml` (+4 -3) 📝 `client/ui/qml/Pages2/PageSettingsDns.qml` (+4 -3) 📝 `client/ui/qml/Pages2/PageSettingsLogging.qml` (+4 -3) _...and 8 more files_ </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-13 21:15:32 +00:00

closed this issue
added the
pull-request
label

No labels

pull-request

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

amnezia-vpn/amnezia-client#1789

No description provided.

Rows
Columns