[PR #556] [MERGED] add navigation using enter + buttons will be clicked if enter (if but… #1913

New issue

Closed

opened 2026-10-13 21:16:41 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-13 21:16:41 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/amnezia-vpn/amnezia-client/pull/556
Author: @agalehaga
Created: 2/4/2024
Status: ✅ Merged
Merged: 2/17/2024
Merged by: @pokamest

Base: dev ← Head: enter_navigation

📝 Commits (10+)

22a8d03 add navigation using enter + buttons will be clicked if enter (if button has focus)
19f509d enter navigation implemented using KeyNavigation
7eaebcc set focus to 1 text field when open page
e3aa642 merge
7055143 removed init functions from pages, default focus is set to timer
5028ebf merge
3fef63e fix merge
331ccd5 add designer style to focus button
bbf61fa ui:qml:BasicButton: anchor when focus = 2
b9b1cb5 PageShare: added bottom margin, fixed setting focus to disabled text fields, fixed qml warnings

📊 Changes

32 files changed (+3130 additions, -3848 deletions)

View changed files

📝 client/translations/amneziavpn_ar.ts (+235 -238)
📝 client/translations/amneziavpn_fa_IR.ts (+898 -1189)
📝 client/translations/amneziavpn_ru.ts (+875 -1107)
📝 client/translations/amneziavpn_zh_CN.ts (+843 -1245)
📝 client/ui/qml/Components/QuestionDrawer.qml (+2 -2)
📝 client/ui/qml/Components/ShareConnectionDrawer.qml (+16 -2)
📝 client/ui/qml/Controls2/BasicButtonType.qml (+63 -26)
📝 client/ui/qml/Controls2/PageType.qml (+15 -0)
📝 client/ui/qml/Controls2/PopupType.qml (+1 -1)
📝 client/ui/qml/Controls2/TextFieldWithHeaderType.qml (+10 -1)
📝 client/ui/qml/Pages2/PageProtocolAwgSettings.qml (+33 -1)
📝 client/ui/qml/Pages2/PageProtocolCloakSettings.qml (+15 -1)
📝 client/ui/qml/Pages2/PageProtocolOpenVpnSettings.qml (+18 -3)
📝 client/ui/qml/Pages2/PageProtocolShadowSocksSettings.qml (+11 -1)
📝 client/ui/qml/Pages2/PageServiceSftpSettings.qml (+3 -3)
📝 client/ui/qml/Pages2/PageServiceTorWebsiteSettings.qml (+1 -1)
📝 client/ui/qml/Pages2/PageSettingsAbout.qml (+5 -3)
📝 client/ui/qml/Pages2/PageSettingsBackup.qml (+2 -2)
📝 client/ui/qml/Pages2/PageSettingsDns.qml (+11 -2)
📝 client/ui/qml/Pages2/PageSettingsServerInfo.qml (+11 -1)

...and 12 more files

📄 Description

Added input navigation to TextFieldWithHeaderType elements - setting focus to the next TextFieldWithHeaderType or button. Also added for buttons is changing the border color if the button is in focus, and processing the Enter and Return button presses (= mouse clicks).

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/amnezia-vpn/amnezia-client/pull/556 **Author:** [@agalehaga](https://github.com/agalehaga) **Created:** 2/4/2024 **Status:** ✅ Merged **Merged:** 2/17/2024 **Merged by:** [@pokamest](https://github.com/pokamest) **Base:** `dev` ← **Head:** `enter_navigation` --- ### 📝 Commits (10+) - [`22a8d03`](https://github.com/amnezia-vpn/amnezia-client/commit/22a8d03931fcde42abba8cbbd5f04ffcdf1a97c1) add navigation using enter + buttons will be clicked if enter (if button has focus) - [`19f509d`](https://github.com/amnezia-vpn/amnezia-client/commit/19f509dfde9d93e314dc8b52296e621ef7b691dd) enter navigation implemented using KeyNavigation - [`7eaebcc`](https://github.com/amnezia-vpn/amnezia-client/commit/7eaebcc10a93fc8f098fb68b768bafaa60d6ea88) set focus to 1 text field when open page - [`e3aa642`](https://github.com/amnezia-vpn/amnezia-client/commit/e3aa642f06f4e98e740fd841fcfc1f5636687c8a) merge - [`7055143`](https://github.com/amnezia-vpn/amnezia-client/commit/70551434a77809d93193da1d4e17af3012620c2b) removed init functions from pages, default focus is set to timer - [`5028ebf`](https://github.com/amnezia-vpn/amnezia-client/commit/5028ebf22e7fdd2e89d7668cf99ea31b320885f9) merge - [`3fef63e`](https://github.com/amnezia-vpn/amnezia-client/commit/3fef63e6c389c70c4b28b14600c659546e2556bd) fix merge - [`331ccd5`](https://github.com/amnezia-vpn/amnezia-client/commit/331ccd56462bbfcf54fe5fb8c43c220595e129f0) add designer style to focus button - [`bbf61fa`](https://github.com/amnezia-vpn/amnezia-client/commit/bbf61fa4dd93c3f9bef1cf8717620def5cdb4f4d) ui:qml:BasicButton: anchor when focus = 2 - [`b9b1cb5`](https://github.com/amnezia-vpn/amnezia-client/commit/b9b1cb55faf6f6785564f4d322937476b973a6ec) PageShare: added bottom margin, fixed setting focus to disabled text fields, fixed qml warnings ### 📊 Changes **32 files changed** (+3130 additions, -3848 deletions) <details> <summary>View changed files</summary> 📝 `client/translations/amneziavpn_ar.ts` (+235 -238) 📝 `client/translations/amneziavpn_fa_IR.ts` (+898 -1189) 📝 `client/translations/amneziavpn_ru.ts` (+875 -1107) 📝 `client/translations/amneziavpn_zh_CN.ts` (+843 -1245) 📝 `client/ui/qml/Components/QuestionDrawer.qml` (+2 -2) 📝 `client/ui/qml/Components/ShareConnectionDrawer.qml` (+16 -2) 📝 `client/ui/qml/Controls2/BasicButtonType.qml` (+63 -26) 📝 `client/ui/qml/Controls2/PageType.qml` (+15 -0) 📝 `client/ui/qml/Controls2/PopupType.qml` (+1 -1) 📝 `client/ui/qml/Controls2/TextFieldWithHeaderType.qml` (+10 -1) 📝 `client/ui/qml/Pages2/PageProtocolAwgSettings.qml` (+33 -1) 📝 `client/ui/qml/Pages2/PageProtocolCloakSettings.qml` (+15 -1) 📝 `client/ui/qml/Pages2/PageProtocolOpenVpnSettings.qml` (+18 -3) 📝 `client/ui/qml/Pages2/PageProtocolShadowSocksSettings.qml` (+11 -1) 📝 `client/ui/qml/Pages2/PageServiceSftpSettings.qml` (+3 -3) 📝 `client/ui/qml/Pages2/PageServiceTorWebsiteSettings.qml` (+1 -1) 📝 `client/ui/qml/Pages2/PageSettingsAbout.qml` (+5 -3) 📝 `client/ui/qml/Pages2/PageSettingsBackup.qml` (+2 -2) 📝 `client/ui/qml/Pages2/PageSettingsDns.qml` (+11 -2) 📝 `client/ui/qml/Pages2/PageSettingsServerInfo.qml` (+11 -1) _...and 12 more files_ </details> ### 📄 Description Added input navigation to TextFieldWithHeaderType elements - setting focus to the next TextFieldWithHeaderType or button. Also added for buttons is changing the border color if the button is in focus, and processing the Enter and Return button presses (= mouse clicks). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-13 21:16:41 +00:00