[PR #666] [MERGED] ISSUE: In start page, icon is highlighted not correctly when press ESC key #2012

New issue

Closed

opened 2026-10-13 21:17:38 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-13 21:17:38 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/amnezia-vpn/amnezia-client/pull/666
Author: @nguyentienldan
Created: 3/4/2024
Status: ✅ Merged
Merged: 3/5/2024
Merged by: @pokamest

Base: dev ← Head: bugfix/Revert_PR_596

📝 Commits (1)

17748cc ISSUE: In start page, icon is highlighted not correctly when press ESC key

📊 Changes

1 file changed (+2 additions, -9 deletions)

View changed files

📝 client/ui/qml/Pages2/PageStart.qml (+2 -9)

📄 Description

ROOT CAUSE: The button state is decided by the attribute isServerInfoShow and it was added by commit 68fe20ddf6. The logic to decide whether server info showed is not correct

ACTION: Revert commit 68fe20ddf6

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/amnezia-vpn/amnezia-client/pull/666 **Author:** [@nguyentienldan](https://github.com/nguyentienldan) **Created:** 3/4/2024 **Status:** ✅ Merged **Merged:** 3/5/2024 **Merged by:** [@pokamest](https://github.com/pokamest) **Base:** `dev` ← **Head:** `bugfix/Revert_PR_596` --- ### 📝 Commits (1) - [`17748cc`](https://github.com/amnezia-vpn/amnezia-client/commit/17748cca474fb07f63f0f45ad6d0ce31d4019b93) ISSUE: In start page, icon is highlighted not correctly when press ESC key ### 📊 Changes **1 file changed** (+2 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `client/ui/qml/Pages2/PageStart.qml` (+2 -9) </details> ### 📄 Description ROOT CAUSE: The button state is decided by the attribute isServerInfoShow and it was added by commit 68fe20ddf637acc45e459f84d1619887e0501f4f. The logic to decide whether server info showed is not correct ACTION: Revert commit 68fe20ddf637acc45e459f84d1619887e0501f4f --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-13 21:17:38 +00:00

closed this issue
added the
pull-request
label

No labels

pull-request

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

amnezia-vpn/amnezia-client#2012

No description provided.

Rows
Columns