[PR #721] [MERGED] Added tab navigation functional. #2059

New issue

Closed

opened 2026-10-13 21:18:06 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-13 21:18:06 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/amnezia-vpn/amnezia-client/pull/721
Author: @Garegin866
Created: 4/1/2024
Status: ✅ Merged
Merged: 4/18/2024
Merged by: @pokamest

Base: dev ← Head: feauture/tab-navigation

📝 Commits (10+)

6b6f096 - Added tab navigation functional.
264a95c - Merged with develop.
70947aa - Fix for android action to work.
d37edb1 - Added Focus for back button components in settings pages.
7cfffaa - Added Focus for back button for all pages and drawers.
5292192 - Added Focus for Connect button
09379d9 - Merged with dev and resolved conflicts.
e132cd7 returned translations and submodules to dev
87279d9 - Added scroll on tab for Servers ListView on PageHome.
e922088 Merge branch 'dev' of github.com:amnezia-vpn/amnezia-client into feauture/tab-navigation

📊 Changes

66 files changed (+2268 additions, -142 deletions)

View changed files

📝 client/ui/controllers/pageController.h (+3 -0)
📝 client/ui/qml/Components/ConnectButton.qml (+23 -4)
📝 client/ui/qml/Components/ConnectionTypeSelectionDrawer.qml (+18 -0)
📝 client/ui/qml/Components/HomeContainersListView.qml (+63 -0)
📝 client/ui/qml/Components/HomeSplitTunnelingDrawer.qml (+24 -0)
📝 client/ui/qml/Components/QuestionDrawer.qml (+21 -0)
📝 client/ui/qml/Components/SelectLanguageDrawer.qml (+69 -6)
📝 client/ui/qml/Components/SettingsContainersListView.qml (+36 -0)
📝 client/ui/qml/Components/ShareConnectionDrawer.qml (+27 -3)
📝 client/ui/qml/Components/TransportProtoSelector.qml (+10 -0)
📝 client/ui/qml/Controls2/BackButtonType.qml (+10 -0)
📝 client/ui/qml/Controls2/BasicButtonType.qml (+12 -1)
📝 client/ui/qml/Controls2/CheckBoxType.qml (+34 -1)
📝 client/ui/qml/Controls2/DropDownType.qml (+93 -46)
📝 client/ui/qml/Controls2/FlickableType.qml (+8 -0)
📝 client/ui/qml/Controls2/Header2Type.qml (+14 -0)
📝 client/ui/qml/Controls2/HeaderType.qml (+16 -0)
📝 client/ui/qml/Controls2/HorizontalRadioButton.qml (+12 -1)
📝 client/ui/qml/Controls2/ImageButtonType.qml (+21 -0)
📝 client/ui/qml/Controls2/LabelWithButtonType.qml (+40 -0)

...and 46 more files

📄 Description

In basic types added parentFlickable property, which will help to ensure, that the item is visible within flickable parent during tab navigation.
Added focus state for some basic types.
In PageType qml file added lastItemTabClicked function, which will help to focus tab bar buttons when the last tab on the current page clicked.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/amnezia-vpn/amnezia-client/pull/721 **Author:** [@Garegin866](https://github.com/Garegin866) **Created:** 4/1/2024 **Status:** ✅ Merged **Merged:** 4/18/2024 **Merged by:** [@pokamest](https://github.com/pokamest) **Base:** `dev` ← **Head:** `feauture/tab-navigation` --- ### 📝 Commits (10+) - [`6b6f096`](https://github.com/amnezia-vpn/amnezia-client/commit/6b6f096a8e6d90f72f0c35a8f855c30a17c6ffe6) - Added tab navigation functional. - [`264a95c`](https://github.com/amnezia-vpn/amnezia-client/commit/264a95c2d021c21c79311e971d7d6f44fbdcfe44) - Merged with develop. - [`70947aa`](https://github.com/amnezia-vpn/amnezia-client/commit/70947aac1af5d618111acc9d65682db1e94161c1) - Fix for android action to work. - [`d37edb1`](https://github.com/amnezia-vpn/amnezia-client/commit/d37edb1b91d8386bf29435019b0bff94221219a5) - Added Focus for back button components in settings pages. - [`7cfffaa`](https://github.com/amnezia-vpn/amnezia-client/commit/7cfffaaa748cf242eb06f2ccf8021758bccc566a) - Added Focus for back button for all pages and drawers. - [`5292192`](https://github.com/amnezia-vpn/amnezia-client/commit/52921922b152542ea4ba789aef0182fe93ef8722) - Added Focus for Connect button - [`09379d9`](https://github.com/amnezia-vpn/amnezia-client/commit/09379d971d60f76775e34950adac719a110eb99f) - Merged with dev and resolved conflicts. - [`e132cd7`](https://github.com/amnezia-vpn/amnezia-client/commit/e132cd7ba2238a3b9c8a0e192e9329982f75a761) returned translations and submodules to dev - [`87279d9`](https://github.com/amnezia-vpn/amnezia-client/commit/87279d90bdd5852b8b30640cd58f333d7b7bab7a) - Added scroll on tab for Servers ListView on PageHome. - [`e922088`](https://github.com/amnezia-vpn/amnezia-client/commit/e92208872c436c0939094844649a40334a14fd50) Merge branch 'dev' of github.com:amnezia-vpn/amnezia-client into feauture/tab-navigation ### 📊 Changes **66 files changed** (+2268 additions, -142 deletions) <details> <summary>View changed files</summary> 📝 `client/ui/controllers/pageController.h` (+3 -0) 📝 `client/ui/qml/Components/ConnectButton.qml` (+23 -4) 📝 `client/ui/qml/Components/ConnectionTypeSelectionDrawer.qml` (+18 -0) 📝 `client/ui/qml/Components/HomeContainersListView.qml` (+63 -0) 📝 `client/ui/qml/Components/HomeSplitTunnelingDrawer.qml` (+24 -0) 📝 `client/ui/qml/Components/QuestionDrawer.qml` (+21 -0) 📝 `client/ui/qml/Components/SelectLanguageDrawer.qml` (+69 -6) 📝 `client/ui/qml/Components/SettingsContainersListView.qml` (+36 -0) 📝 `client/ui/qml/Components/ShareConnectionDrawer.qml` (+27 -3) 📝 `client/ui/qml/Components/TransportProtoSelector.qml` (+10 -0) 📝 `client/ui/qml/Controls2/BackButtonType.qml` (+10 -0) 📝 `client/ui/qml/Controls2/BasicButtonType.qml` (+12 -1) 📝 `client/ui/qml/Controls2/CheckBoxType.qml` (+34 -1) 📝 `client/ui/qml/Controls2/DropDownType.qml` (+93 -46) 📝 `client/ui/qml/Controls2/FlickableType.qml` (+8 -0) 📝 `client/ui/qml/Controls2/Header2Type.qml` (+14 -0) 📝 `client/ui/qml/Controls2/HeaderType.qml` (+16 -0) 📝 `client/ui/qml/Controls2/HorizontalRadioButton.qml` (+12 -1) 📝 `client/ui/qml/Controls2/ImageButtonType.qml` (+21 -0) 📝 `client/ui/qml/Controls2/LabelWithButtonType.qml` (+40 -0) _...and 46 more files_ </details> ### 📄 Description - In basic types added parentFlickable property, which will help to ensure, that the item is visible within flickable parent during tab navigation. - Added focus state for some basic types. - In PageType qml file added lastItemTabClicked function, which will help to focus tab bar buttons when the last tab on the current page clicked. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-13 21:18:06 +00:00

closed this issue
added the
pull-request
label

No labels

pull-request

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

amnezia-vpn/amnezia-client#2059

No description provided.

Rows
Columns