[PR #1464] [MERGED] Focus Control fixes #2371

Closed
opened 2026-10-13 21:21:24 +00:00 by bsakaguchi · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/amnezia-vpn/amnezia-client/pull/1464
Author: @CyAn84
Created: 3/8/2025
Status: ✅ Merged
Merged: 8/6/2025
Merged by: @Nethius

Base: dev ← Head: chore/focus_control


📝 Commits (10+)

  • a7e812f change position view mode
  • 5533ce5 remove parentFlickable from PageShare
  • 2b0faca replace FlickableType with ListViewType in PageSettings
  • 62770f4 reorganize PageSettingsAbout for improved structure
  • b0fb349 replace Flickable with ListViewType in drawer in PageSettingsApiNativeConfigs
  • 73f94e1 replace FlickableType with ListViewType in PageSettingsApplication and update layout structure
  • 1a08b24 replace FlickableType with ListViewType in PageSettingsAppSplitTunneling and adjust layout for better structure
  • ad119d5 replace FlickableType with ListViewType in PageSettingsBackup
  • 04ee62e replace FlickableType with ListViewType in PageSettingsConnection
  • 405bd70 replace FlickableType with ListViewType in PageSettingsDns

📊 Changes

56 files changed (+5337 additions, -5625 deletions)

View changed files

📝 client/ui/controllers/listViewFocusController.cpp (+1 -1)
📝 client/ui/qml/Components/HomeContainersListView.qml (+1 -9)
📝 client/ui/qml/Components/HomeSplitTunnelingDrawer.qml (+97 -97)
📝 client/ui/qml/Components/InstalledAppsDrawer.qml (+18 -32)
📝 client/ui/qml/Components/SelectLanguageDrawer.qml (+1 -7)
📝 client/ui/qml/Components/ServersListView.qml (+1 -8)
📝 client/ui/qml/Components/SettingsContainersListView.qml (+41 -55)
📝 client/ui/qml/Controls2/BasicButtonType.qml (+210 -220)
📝 client/ui/qml/Controls2/CardWithIconsType.qml (+185 -203)
📝 client/ui/qml/Controls2/CheckBoxType.qml (+187 -170)
📝 client/ui/qml/Controls2/LabelWithButtonType.qml (+309 -328)
📝 client/ui/qml/Controls2/ListViewType.qml (+8 -25)
📝 client/ui/qml/Controls2/ListViewWithRadioButtonType.qml (+1 -8)
📝 client/ui/qml/Controls2/SwitcherType.qml (+162 -172)
📝 client/ui/qml/Controls2/TextAreaType.qml (+135 -118)
📝 client/ui/qml/Controls2/TextAreaWithFooterType.qml (+171 -180)
📝 client/ui/qml/Controls2/TextFieldWithHeaderType.qml (+220 -233)
📝 client/ui/qml/Pages2/PageDeinstalling.qml (+38 -48)
📝 client/ui/qml/Pages2/PageDevMenu.qml (+3 -13)
📝 client/ui/qml/Pages2/PageProtocolAwgClientSettings.qml (+303 -258)

...and 36 more files

📄 Description

This PR adds refactor to screens to replace Flickable items with ListView to have better experience with focus navigation.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/amnezia-vpn/amnezia-client/pull/1464 **Author:** [@CyAn84](https://github.com/CyAn84) **Created:** 3/8/2025 **Status:** ✅ Merged **Merged:** 8/6/2025 **Merged by:** [@Nethius](https://github.com/Nethius) **Base:** `dev` ← **Head:** `chore/focus_control` --- ### 📝 Commits (10+) - [`a7e812f`](https://github.com/amnezia-vpn/amnezia-client/commit/a7e812f6b29607a261d6586440c89c12c117a289) change position view mode - [`5533ce5`](https://github.com/amnezia-vpn/amnezia-client/commit/5533ce56d7110ebb1e6e37ff8f90ab8ccecfc30e) remove `parentFlickable` from `PageShare` - [`2b0faca`](https://github.com/amnezia-vpn/amnezia-client/commit/2b0faca3621a4cb79426956951a6bec6e255084b) replace `FlickableType` with `ListViewType` in `PageSettings` - [`62770f4`](https://github.com/amnezia-vpn/amnezia-client/commit/62770f4c0471fb9506aa8ce4b6521f151f17ee4d) reorganize `PageSettingsAbout` for improved structure - [`b0fb349`](https://github.com/amnezia-vpn/amnezia-client/commit/b0fb3491ca0532b7a901703a0f59652d9105ac20) replace `Flickable` with `ListViewType` in drawer in `PageSettingsApiNativeConfigs` - [`73f94e1`](https://github.com/amnezia-vpn/amnezia-client/commit/73f94e1277d2d7039581db08d0b4b78107251012) replace `FlickableType` with `ListViewType` in `PageSettingsApplication` and update layout structure - [`1a08b24`](https://github.com/amnezia-vpn/amnezia-client/commit/1a08b24cb8d8028520f4ca247f6502e1801a2cb3) replace `FlickableType` with `ListViewType` in `PageSettingsAppSplitTunneling` and adjust layout for better structure - [`ad119d5`](https://github.com/amnezia-vpn/amnezia-client/commit/ad119d5de5e5202da4b8f2e2f662b76e1241b5f9) replace `FlickableType` with `ListViewType` in `PageSettingsBackup` - [`04ee62e`](https://github.com/amnezia-vpn/amnezia-client/commit/04ee62ea90ff4492def088250292cc1593a5bdff) replace `FlickableType` with `ListViewType` in `PageSettingsConnection` - [`405bd70`](https://github.com/amnezia-vpn/amnezia-client/commit/405bd702675e227c720af7c23ca0f9c92ba61a09) replace `FlickableType` with `ListViewType` in `PageSettingsDns` ### 📊 Changes **56 files changed** (+5337 additions, -5625 deletions) <details> <summary>View changed files</summary> 📝 `client/ui/controllers/listViewFocusController.cpp` (+1 -1) 📝 `client/ui/qml/Components/HomeContainersListView.qml` (+1 -9) 📝 `client/ui/qml/Components/HomeSplitTunnelingDrawer.qml` (+97 -97) 📝 `client/ui/qml/Components/InstalledAppsDrawer.qml` (+18 -32) 📝 `client/ui/qml/Components/SelectLanguageDrawer.qml` (+1 -7) 📝 `client/ui/qml/Components/ServersListView.qml` (+1 -8) 📝 `client/ui/qml/Components/SettingsContainersListView.qml` (+41 -55) 📝 `client/ui/qml/Controls2/BasicButtonType.qml` (+210 -220) 📝 `client/ui/qml/Controls2/CardWithIconsType.qml` (+185 -203) 📝 `client/ui/qml/Controls2/CheckBoxType.qml` (+187 -170) 📝 `client/ui/qml/Controls2/LabelWithButtonType.qml` (+309 -328) 📝 `client/ui/qml/Controls2/ListViewType.qml` (+8 -25) 📝 `client/ui/qml/Controls2/ListViewWithRadioButtonType.qml` (+1 -8) 📝 `client/ui/qml/Controls2/SwitcherType.qml` (+162 -172) 📝 `client/ui/qml/Controls2/TextAreaType.qml` (+135 -118) 📝 `client/ui/qml/Controls2/TextAreaWithFooterType.qml` (+171 -180) 📝 `client/ui/qml/Controls2/TextFieldWithHeaderType.qml` (+220 -233) 📝 `client/ui/qml/Pages2/PageDeinstalling.qml` (+38 -48) 📝 `client/ui/qml/Pages2/PageDevMenu.qml` (+3 -13) 📝 `client/ui/qml/Pages2/PageProtocolAwgClientSettings.qml` (+303 -258) _...and 36 more files_ </details> ### 📄 Description This PR adds refactor to screens to replace `Flickable` items with `ListView` to have better experience with focus navigation. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
bsakaguchi 2026-10-13 21:21:25 +00:00
Sign in to join this conversation.
No labels
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
amnezia-vpn/amnezia-client#2371
No description provided.