[PR #2141] [CLOSED] fix: enhance encryption handling in SecureQSettings #2675

New issue

Closed

opened 2026-10-14 21:03:55 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-14 21:03:55 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/amnezia-vpn/amnezia-client/pull/2141
Author: @aiamnezia
Created: 1/20/2026
Status: ❌ Closed

Base: dev ← Head: fix/qsecuresettings-with-android

📝 Commits (1)

238d149 fix: enhance encryption handling in SecureQSettings

📊 Changes

2 files changed (+20 additions, -10 deletions)

View changed files

📝 client/secure_qsettings.cpp (+18 -9)
📝 client/secure_qsettings.h (+2 -1)

📄 Description

Updated encryptText to return std::optional for better error handling.
Added fallback to plaintext storage if encryption fails in setValue method.
Improved logging for encryption errors and empty key scenarios.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/amnezia-vpn/amnezia-client/pull/2141 **Author:** [@aiamnezia](https://github.com/aiamnezia) **Created:** 1/20/2026 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `fix/qsecuresettings-with-android` --- ### 📝 Commits (1) - [`238d149`](https://github.com/amnezia-vpn/amnezia-client/commit/238d149593ab0ff085bba3a2f3aff0738ef2922d) fix: enhance encryption handling in SecureQSettings ### 📊 Changes **2 files changed** (+20 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `client/secure_qsettings.cpp` (+18 -9) 📝 `client/secure_qsettings.h` (+2 -1) </details> ### 📄 Description * Updated encryptText to return std::optional<QByteArray> for better error handling. * Added fallback to plaintext storage if encryption fails in setValue method. * Improved logging for encryption errors and empty key scenarios. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-14 21:03:55 +00:00

closed this issue
added the
pull-request
label

No labels

pull-request

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

amnezia-vpn/amnezia-client#2675

No description provided.

Rows
Columns