[PR #2357] fix: address AmneziaDNS deploy regressions #2779

New issue

Open

opened 2026-10-14 21:05:14 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-14 21:05:14 +00:00

Owner

Original Pull Request: https://github.com/amnezia-vpn/amnezia-client/pull/2357

State: open
Merged: No

Summary

This PR fixes three regressions encountered during AWG + AmneziaDNS installation and adds regression coverage for them.

suppress the noisy missing start.sh warning for containers whose startup script is optional
prevent Enter / Return in TextFieldWithHeaderType from triggering a hidden right-button action
fix the undefined removeButton reference on the AmneziaDNS settings page
add focused regression tests for the script registry path and the affected QML behavior

Root Cause

The DNS deploy flow reused the generic container startup path, which always attempted to load :/server_scripts/<container>/start.sh even for containers where that resource does not exist. In parallel, the shared QML text field control invoked its action handler on Enter / Return without checking whether a right-side button was actually visible, and the DNS settings page referenced removeButton without declaring the id.

Test Plan

cmake -S . -B build -DBUILD_TESTING=ON
cmake --build build -j
`ctest --test-dir build-tests --output-on-failure -R 'tst_scripts_registry|tst_client_qml'

**Original Pull Request:** https://github.com/amnezia-vpn/amnezia-client/pull/2357 **State:** open **Merged:** No --- ## Summary This PR fixes three regressions encountered during AWG + AmneziaDNS installation and adds regression coverage for them. - suppress the noisy missing `start.sh` warning for containers whose startup script is optional - prevent `Enter` / `Return` in `TextFieldWithHeaderType` from triggering a hidden right-button action - fix the undefined `removeButton` reference on the AmneziaDNS settings page - add focused regression tests for the script registry path and the affected QML behavior ## Root Cause The DNS deploy flow reused the generic container startup path, which always attempted to load `:/server_scripts/<container>/start.sh` even for containers where that resource does not exist. In parallel, the shared QML text field control invoked its action handler on `Enter` / `Return` without checking whether a right-side button was actually visible, and the DNS settings page referenced `removeButton` without declaring the id. ## Test Plan - `cmake -S . -B build -DBUILD_TESTING=ON` - `cmake --build build -j` - `ctest --test-dir build-tests --output-on-failure -R 'tst_scripts_registry|tst_client_qml'

bsakaguchi added the

pull-request

label

2026-10-14 21:05:14 +00:00

bsakaguchi referenced this issue

2026-10-14 21:06:24 +00:00

[PR #2779] fix: add accessible labels to core controls #2944