[PR #2661] [MERGED] Updating install_docker.sh script #2891

New issue

Closed

opened 2026-10-14 21:06:00 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-14 21:06:00 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/amnezia-vpn/amnezia-client/pull/2661
Author: @lunardunno
Created: 5/27/2026
Status: ✅ Merged
Merged: 6/15/2026
Merged by: @vkamn

Base: dev ← Head: feat/implementing_docker_service_checking

📝 Commits (10+)

15669b3 Updating install_docker.sh script
66103da adding message handling to install controller
7931317 Error Codes added
d194e01 Adding extended descriptions of new errors
b43e16d Merge branch 'dev' into feat/implementing_docker_service_checking
9cdd4fe fix last line in errorCodes.h
84c76d7 fix last line in errorStrings.cpp
c1f606a Changing the names of errors
173ebc8 various changes in the script
249c6cd processed phrases have been changed

📊 Changes

6 files changed (+60 additions, -37 deletions)

View changed files

📝 client/core/controllers/selfhosted/installController.cpp (+15 -4)
📝 client/core/utils/errorCodes.h (+2 -2)
📝 client/core/utils/errorStrings.cpp (+2 -0)
📝 client/server_scripts/check_server_is_busy.sh (+8 -7)
📝 client/server_scripts/check_user_in_sudo.sh (+5 -5)
📝 client/server_scripts/install_docker.sh (+28 -19)

📄 Description

Implementing a Docker service status check.
The Docker reinstall step has been removed due to the implementation of Docker service checking. Implementing locale checking and assignment.
Implementation of execution of some actions through commands with sudo, to reduce delays caused by differences in the values of the PATH variable for the root user and the user included in the sudo group.
Implementation of a verification step for the install containerization app to avoid installing unsupported podman-docker applications.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/amnezia-vpn/amnezia-client/pull/2661 **Author:** [@lunardunno](https://github.com/lunardunno) **Created:** 5/27/2026 **Status:** ✅ Merged **Merged:** 6/15/2026 **Merged by:** [@vkamn](https://github.com/vkamn) **Base:** `dev` ← **Head:** `feat/implementing_docker_service_checking` --- ### 📝 Commits (10+) - [`15669b3`](https://github.com/amnezia-vpn/amnezia-client/commit/15669b3f984c76b4bf398b401b228d6efd7ee780) Updating install_docker.sh script - [`66103da`](https://github.com/amnezia-vpn/amnezia-client/commit/66103dac5afc812cf7272e18308a2c321e836c72) adding message handling to install controller - [`7931317`](https://github.com/amnezia-vpn/amnezia-client/commit/7931317decb3eb2ac7d8f876c7620ad58c0db894) Error Codes added - [`d194e01`](https://github.com/amnezia-vpn/amnezia-client/commit/d194e01fc0cc34be8d18be32d1a46ac3ecd74485) Adding extended descriptions of new errors - [`b43e16d`](https://github.com/amnezia-vpn/amnezia-client/commit/b43e16d2eccef3119e38ba503d300ab88606d5e2) Merge branch 'dev' into feat/implementing_docker_service_checking - [`9cdd4fe`](https://github.com/amnezia-vpn/amnezia-client/commit/9cdd4fe8d213bb9a234aa8bfc165f19b5ee643a7) fix last line in errorCodes.h - [`84c76d7`](https://github.com/amnezia-vpn/amnezia-client/commit/84c76d75da025946610abc4595cd90fdb847aaca) fix last line in errorStrings.cpp - [`c1f606a`](https://github.com/amnezia-vpn/amnezia-client/commit/c1f606a18ac9788fed1c3a89953e041bee679b21) Changing the names of errors - [`173ebc8`](https://github.com/amnezia-vpn/amnezia-client/commit/173ebc861eb26a6f2799bafed42a5083847cf673) various changes in the script - [`249c6cd`](https://github.com/amnezia-vpn/amnezia-client/commit/249c6cda29c0d2605f70f45273c4e86a7314416e) processed phrases have been changed ### 📊 Changes **6 files changed** (+60 additions, -37 deletions) <details> <summary>View changed files</summary> 📝 `client/core/controllers/selfhosted/installController.cpp` (+15 -4) 📝 `client/core/utils/errorCodes.h` (+2 -2) 📝 `client/core/utils/errorStrings.cpp` (+2 -0) 📝 `client/server_scripts/check_server_is_busy.sh` (+8 -7) 📝 `client/server_scripts/check_user_in_sudo.sh` (+5 -5) 📝 `client/server_scripts/install_docker.sh` (+28 -19) </details> ### 📄 Description Implementing a Docker service status check. The Docker reinstall step has been removed due to the implementation of Docker service checking. Implementing locale checking and assignment. Implementation of execution of some actions through commands with sudo, to reduce delays caused by differences in the values of the PATH variable for the root user and the user included in the sudo group. Implementation of a verification step for the install containerization app to avoid installing unsupported podman-docker applications. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-14 21:06:00 +00:00

closed this issue
added the
pull-request
label

No labels

pull-request

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

amnezia-vpn/amnezia-client#2891

No description provided.

Rows
Columns